Cannot use nixpkgs-review rev HEAD to check local commits added to an existing pull request

[dwt]

This can be seen on NixOS/nixpkgs#366387 where I tried to checkout a PR do some local modifications and then tried to build it. That got me errors like this.

Now... did I do something wrong there or is this expected behavior? Quite possibly I do not understand correctly how it is supposed to work to improve pull requests from other people and make (tested) suggestions on how to improve them.

[dwt]

I am hitting this problem repeatedly. Basically whenever I have local changes to a nixpkgs pull request that I would like to test as a feedback to the pull request provider, I cannot seem to be able to do this with nix-review. Things I tried:

• nix-review rev HEAD builds quite a lot of stuff, but never so far what was in the pull request
• nix-review rev $git_head_commit_id same
• nix-review rev HEAD --branch master same
• nix-review rev HEAD --branch $previous_git_commit_id seems to work better, as in the two versions of nixpkgs that are evaluated to find the changed packages look correct now, but still builds something, but not what is in the pull request

At this point I'm running out of ideas, all the other options do not seem applicable.

[dwt]

Some workarounds I'm using: create a draft pull request and check it with nix-review pr $id, or just build with nix build .#$package and provide feedback that way.