--eval github sometimes reports urllib.error.HTTPError: HTTP Error 410: Gone

[FliegendeWurst]

For example, when trying to review NixOS/nixpkgs#362297.

I would assume the error occurs because the eval artifact disappeared.

I think the error should be reported without dumping a stacktrace on the user. Ideally it would then evaluate locally.

Traceback (most recent call last):
  File "/nix/store/4av055vaj05smk7spcskwkpdhy90qgam-nixpkgs-review-3.0.1/bin/.nixpkgs-review-wrapped", line 9, in <module>
    sys.exit(main())
             ^^^^^^
  File "/nix/store/4av055vaj05smk7spcskwkpdhy90qgam-nixpkgs-review-3.0.1/lib/python3.12/site-packages/nixpkgs_review/__init__.py", line 10, in main
    cli.main(command, args)
  File "/nix/store/4av055vaj05smk7spcskwkpdhy90qgam-nixpkgs-review-3.0.1/lib/python3.12/site-packages/nixpkgs_review/cli/__init__.py", line 341, in main
    return cast(str, args.func(args))
                     ^^^^^^^^^^^^^^^
  File "/nix/store/4av055vaj05smk7spcskwkpdhy90qgam-nixpkgs-review-3.0.1/lib/python3.12/site-packages/nixpkgs_review/cli/pr.py", line 115, in pr_command
    contexts.append((pr, builddir.path, review.build_pr(pr)))
                                        ^^^^^^^^^^^^^^^^^^^
  File "/nix/store/4av055vaj05smk7spcskwkpdhy90qgam-nixpkgs-review-3.0.1/lib/python3.12/site-packages/nixpkgs_review/review.py", line 302, in build_pr
    packages_per_system = self.github_client.get_github_action_eval_result(pr)
                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/4av055vaj05smk7spcskwkpdhy90qgam-nixpkgs-review-3.0.1/lib/python3.12/site-packages/nixpkgs_review/github.py", line 183, in get_github_action_eval_result
    changed_paths: Any = self.get_json_from_artifact(
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/4av055vaj05smk7spcskwkpdhy90qgam-nixpkgs-review-3.0.1/lib/python3.12/site-packages/nixpkgs_review/github.py", line 118, in get_json_from_artifact
    with no_redirect_opener.open(req) as resp:

[bbigras]

I had this same problem today with an old PR.

Ideally it would then evaluate locally.

+1

[Mic92]

We should treat 410 the same way as 404.