Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make {create/update}TypeAliasDeclaration API consistent (closes #15918) #15940

Merged
merged 2 commits into from
May 19, 2017
Merged

Make {create/update}TypeAliasDeclaration API consistent (closes #15918) #15940

merged 2 commits into from
May 19, 2017

Conversation

phated
Copy link
Contributor

@phated phated commented May 18, 2017

Fixes #15918

@sandersn
Copy link
Member

@phated can you fix the build break before I merge this? Callers of updateTypeAliasDeclaration need to be updated.

@phated
Copy link
Contributor Author

phated commented May 19, 2017

No problem. I didn't realize it was being used internally already.

@phated
Copy link
Contributor Author

phated commented May 19, 2017

Alright, based on the travis run, I think I've updated this properly.

@sandersn sandersn merged commit d5993ba into microsoft:master May 19, 2017
@sandersn
Copy link
Member

Thanks @phated!

@renovate-bot renovate-bot mentioned this pull request May 22, 2017
Merged
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sandersn sandersn sandersn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phated @sandersn @msftclas