Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable TestContext.AddResultFile API for WinUI #1593

Merged
merged 26 commits into from
May 26, 2023
Merged

Enable TestContext.AddResultFile API for WinUI #1593

merged 26 commits into from
May 26, 2023

Conversation

engyebrahim
Copy link
Member

@engyebrahim engyebrahim commented Feb 14, 2023 •
edited
Loading

fix: #727 and #1594

@engyebrahim
add tests
e5b5740
@engyebrahim
Revert "add tests"
ba6500d 
This reverts commit e5b5740.
@engyebrahim
Merge branch 'main' of https://github.com/microsoft/testfx
d17a9f0
@engyebrahim
Merge branch 'main' of https://github.com/microsoft/testfx
2fa3202
@engyebrahim
Merge branch 'main' of https://github.com/microsoft/testfx
403fb59
@engyebrahim
Merge branch 'main' of https://github.com/microsoft/testfx
d3726f4
@engyebrahim
Merge branch 'main' of https://github.com/microsoft/testfx
407efd9
@engyebrahim
Merge branch 'main' of https://github.com/microsoft/testfx
9daa7fb
@engyebrahim
Merge branch 'main' of https://github.com/microsoft/testfx
405d426
@engyebrahim
Merge remote-tracking branch 'microsoft/main'
6685113
@engyebrahim
Merge branch 'main' of https://github.com/microsoft/testfx
cd5cff9
@engyebrahim
Merge branch 'main' of https://github.com/microsoft/testfx
94ba876
@engyebrahim
update doc
e798040
@engyebrahim
update the msg
da1ea53
@engyebrahim
fix
1fffc7d
@engyebrahim
fix
a9ec5b8
@engyebrahim
Merge branch 'main' of https://github.com/microsoft/testfx
5362a00
@engyebrahim
Merge branch 'main' of https://github.com/microsoft/testfx
3c2ec83
@engyebrahim
Merge branch 'main' of https://github.com/microsoft/testfx
f79a8f2
@engyebrahim
fix
95ec1e3
@engyebrahim
fix
469725c
@engyebrahim
Merge branch 'main' of https://github.com/engyebrahim/testfx
9854250
@engyebrahim
Merge branch 'main' of https://github.com/microsoft/testfx
481e067
@engyebrahim
Merge branch 'main' of https://github.com/microsoft/testfx
97c60fc
@engyebrahim
enable AddResultFile for uwp
5ca0c66
MSLukeWest
MSLukeWest previously approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@MSLukeWest MSLukeWest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure to let me know when this gets inserted into VS so I can do some additional testing.

@engyebrahim engyebrahim changed the title enable 'add result file' in test context on uwp enable 'add result file' in test context on uwp and win_ui Feb 16, 2023
@Evangelink
Copy link
Member

@engyebrahim What's the status of this PR?

@Evangelink
Copy link
Member

Ping @engyebrahim

Evangelink
Evangelink approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per my tests this seems to be working only for WinUI. I suspect that UWP provider is ignoring this info we are providing.

Please double check if you see the same behaviour. Approving now so you can merge when you are done with testing.

@Evangelink Evangelink changed the title enable 'add result file' in test context on uwp and win_ui Enable TestContext.AddResultFile API for WinUI May 25, 2023
@engyebrahim engyebrahim merged commit 35e1214 into microsoft:main May 26, 2023
@Evangelink Evangelink mentioned this pull request May 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evangelink Evangelink Evangelink approved these changes

@MSLukeWest MSLukeWest MSLukeWest approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No 'AddResultFile' implementation in TestContext on UWP test project
3 participants
@engyebrahim @Evangelink @MSLukeWest