Base class data rows should not be executed #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singhsarab
reviewed
Dec 20, 2018
| @@ -303,7 +303,7 @@ internal UnitTestResult[] RunTestMethod() | |||
| } | |||
| else | |||
| { | |||
| UTF.ITestDataSource[] testDataSources = this.testMethodInfo.GetAttributes<Attribute>(true)?.Where(a => a is UTF.ITestDataSource).OfType<UTF.ITestDataSource>().ToArray(); | |||
| UTF.ITestDataSource[] testDataSources = this.testMethodInfo.GetAttributes<Attribute>(false)?.Where(a => a is UTF.ITestDataSource).OfType<UTF.ITestDataSource>().ToArray(); | |||
singhsarab
reviewed
Jan 10, 2019
| // 4 tests of BaseClass - 3 datarow result and 1 parent result | ||
| // 3 tests of DerivedClass - 2 datarow result and 1 parent result | ||
| // Total 7 tests - Making sure that DerivedClass doesn't run BaseClass tests | ||
| this.ValidatePassedTestsCount(7); |
There was a problem hiding this comment.
This is little confusing.
We should rather run only the DerviedClass tests using filter maybe and then check for only that.
We can keep this one as well.
There was a problem hiding this comment.
Didn't realize the confusion. Added new test.
singhsarab
reviewed
Jan 10, 2019
| { | ||
| this.InvokeVsTestForExecution(new string[] { TestAssembly }, testCaseFilter: "FullyQualifiedName~DerivedClass"); | ||
|
|
||
| this.ValidatePassedTestsContain( |
There was a problem hiding this comment.
Shouldn't this validation change after using the filter ?
There was a problem hiding this comment.
By mistake added filter in first test.
singhsarab
approved these changes
Jan 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#458
Need to add tests.