Test Explorer : Remove time from all nodes except the tests

[DonJayamanne]

When using pytest-xdist for parallel test execution, the total time taken is NOT the same as the sum total of all tests.

[DonJayamanne]

@luabud we'll need to prioritize this, hence adding a label of needs decision.

[DonJayamanne]

Here's what we do today:

• We display a summary for each node in the tree
  • For folder (nodes) we display the sum total of all child nodes
  • For file (nodes) we display the sum total of all child nodes

Unfortunately

• When running tests in parallel, the test runner is responsible for the tests, not us
• We have no idea what ran in parallet and what didn'
• So, its possible two files ran in parallel, and displaying a total time for a folder node makes no sense, as this information is not available (at the end of the day test frameworks/runners deal with tests not folders)
• By the same token we don't know how long a test file took to complete, all we know is how long each individual test in the file took.
  • Again, displaying the total time taken for all tests in a file is wrong & not possible.
  • Tests can run in parallel, and we don't any information related to the parallelism
• Same applies to a test suite...

Suggestion

• We display the time taken to run tests ONLY for each test function (not a folder, not a file, & not for a suite)
• We can display the total time taken to run the tests at the root folder, ONLY if there is ONE root folder.
  • This is because we only know how long ALL tests took
  • If we have tests in two folders at the top level, then we don't know how long each folder took...
• This change will have to be made across the board, as we have no idea what tests ran in parallel and what didn't, & we shouldn't try to guess nor assume (unnecessary hacks).

@luabud /cc

So, the only change we need to make is simple:

• No test duration for files, folders and suites
• Add total duration for the root node if there is one root folder node, else no time summary.

[DonJayamanne]

Prescribed Solution:

• Display the time only for the individual test
• Do not display summary for parameterized test, suite, file, folder (i.e. do not calculate the total durations)
• Modify src/client/testing/explorer/testTreeViewItem.ts accordingly (check the property testType to determine whether its a function or not.

[ericsnowcurrently]

validated