Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new EventArgs of onDidChangeConfiguration to determine what settings changed #642

Closed
DonJayamanne opened this issue Jan 27, 2018 · 1 comment
Closed

Use new EventArgs of onDidChangeConfiguration to determine what settings changed #642

DonJayamanne opened this issue Jan 27, 2018 · 1 comment
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc. good first issue

Comments

@DonJayamanne
Copy link

DonJayamanne commented Jan 27, 2018 •
edited
Loading

Make use of the eventargs of onDidChangeConfigurationEvent to determine what changed and accordingly act on this.
Currently we do do check what changed, and if we do, we perform our own comparisons to determine if there are any changes.
@DonJayamanne DonJayamanne added awaiting 2-PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels Jan 27, 2018
@DonJayamanne DonJayamanne changed the title Use new onDidChangeConfiguration event args to determine what changed Use new EventArgs of onDidChangeConfiguration to determine what settings changed Jan 27, 2018
@DonJayamanne DonJayamanne self-assigned this Jan 15, 2019
@DonJayamanne DonJayamanne mentioned this issue Jan 15, 2019
Merged
3 tasks
DonJayamanne added a commit that referenced this issue Jan 17, 2019
@DonJayamanne
Expose an event to notify changes to settings instead of casting sett…
57fca15 
…ings to concrete class (#3990)

For #642
@DonJayamanne DonJayamanne removed their assignment Feb 28, 2019
@luabud
Copy link
Member

luabud commented Feb 12, 2020

Seems to be merged.

@luabud luabud closed this as completed Feb 12, 2020
@ghost ghost removed the needs PR label Feb 12, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc. good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brettcannon @DonJayamanne @luabud