Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building on Stable #29

Closed
zrneely opened this issue Oct 28, 2015 · 5 comments
Closed

Building on Stable #29

zrneely opened this issue Oct 28, 2015 · 5 comments

Comments

@zrneely
Copy link
Contributor

zrneely commented Oct 28, 2015

Is there any progress or desire for progress towards getting this library to build on the stable branch? Or is there no way around use of the mpsc select feature?

@laumann
Copy link
Collaborator

laumann commented Oct 29, 2015

There is little/no progress, because we figured that eventually mpsc select will become stable.

Getting rid of mpsc select either requires implementing Select functionality from scratch, or removing it entirely - neither option is very attractive. Although, from https://github.com/rust-lang/rust/blob/stable/src/libstd/sync/mpsc/select.rs, it doesn't seem like Select depends on unstable features...

One solution could be to maintain a separate branch of session types that builds on stable, would that work for you?

@zrneely
Copy link
Contributor Author

zrneely commented Oct 29, 2015

I'm not suggesting that you maintain a whole separate branch (!) - I can make a local copy/fork without the Select functionality (which I don't use). I was just wondering what the plans are regarding this, especially since I've had a hard time finding an RFC or issue regarding the mpsc_select feature on the main rust repo.

@zrneely zrneely closed this as completed Oct 29, 2015
@laumann
Copy link
Collaborator

laumann commented Oct 29, 2015

Ah ok - yeah, the mpsc_select feature has been unstable for a while (as long as I've worked with Rust, at least), and there doesn't really seem to be any progress towards stabilizing it.

The short answer is: We'd be interested in having session-types build on stable, but it doesn't have high priority.

@mbudde
Copy link

mbudde commented Oct 29, 2015

The tracking issue for mpsc_select is #27800.

Have you considered using Cargo "features" to make the select feature optional?

@Munksgaard
Copy link
Owner

Have you considered using Cargo "features" to make the select feature optional?

That sounds like a good compromise while we wait for stabilization 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants