Skip to content

Commit e4540be

Browse files
committedJan 27, 2025
[TASK] Drop PHP_CodeSniffer
The GPG keys used to sign the PHARs are no longer available, which breaks installation of PHP_CodeSniffer (and its fixer), which breaks the build. In `main`, we already dropped the tool in #468.
1 parent 6f37a7a commit e4540be

File tree

4 files changed

+2
-29
lines changed

4 files changed

+2
-29
lines changed
 

‎.github/workflows/ci.yml

+1-3
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,6 @@ jobs:
8585
fail-fast: false
8686
matrix:
8787
include:
88-
- command: sniffer
89-
php-version: '7.4'
9088
- command: fixer
9189
php-version: '7.4'
9290
- command: stan
@@ -121,7 +119,7 @@ jobs:
121119
122120
- name: Install development tools
123121
run: |
124-
phive --no-progress install --trust-gpg-keys 0FDE18AE1D09E19F60F6B1CBC00543248C87FB13,BBAB5DF0A0D6672989CF1869E82B2FB314E9906E,689DAD778FF08760E046228BA978220305CD5C32,CA7C2C7A30C8E8E1274A847651C67305FFC2E5C0
122+
phive --no-progress install --trust-gpg-keys BBAB5DF0A0D6672989CF1869E82B2FB314E9906E,CA7C2C7A30C8E8E1274A847651C67305FFC2E5C0,D32680D5957DC7116BE29C14CF1A108D0E7AE720
125123
126124
- name: Run Command
127125
run: composer ci:php:${{ matrix.command }}

‎.phive/phars.xml

-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<phive xmlns="https://phar.io/phive">
33
<phar name="php-cs-fixer" version="^3.13.2" installed="3.68.1" location="./.phive/php-cs-fixer.phar" copy="false"/>
4-
<phar name="phpcbf" version="^3.7.1" installed="3.11.2" location="./.phive/phpcbf.phar" copy="false"/>
5-
<phar name="phpcs" version="^3.7.1" installed="3.11.2" location="./.phive/phpcs.phar" copy="false"/>
64
<phar name="phpstan" version="^1.9.14" installed="1.12.15" location="./.phive/phpstan.phar" copy="false"/>
75
</phive>

‎composer.json

+1-7
Original file line numberDiff line numberDiff line change
@@ -52,30 +52,24 @@
5252
"@ci:static"
5353
],
5454
"ci:php:fixer": "@php ./.phive/php-cs-fixer.phar --config=config/php-cs-fixer.php fix --dry-run -v --show-progress=dots bin src tests",
55-
"ci:php:sniffer": "@php ./.phive/phpcs.phar --standard=config/phpcs.xml bin src tests",
5655
"ci:php:stan": "@php ./.phive/phpstan.phar --configuration=config/phpstan.neon",
5756
"ci:static": [
5857
"@ci:php:fixer",
59-
"@ci:php:sniffer",
6058
"@ci:php:stan"
6159
],
6260
"fix:php": [
63-
"@fix:php:fixer",
64-
"@fix:php:sniffer"
61+
"@fix:php:fixer"
6562
],
6663
"fix:php:fixer": "@php ./.phive/php-cs-fixer.phar --config=config/php-cs-fixer.php fix bin src tests",
67-
"fix:php:sniffer": "@php ./.phive/phpcbf.phar --standard=config/phpcs.xml bin src tests",
6864
"phpstan:baseline": "@php ./.phive/phpstan.phar --configuration=config/phpstan.neon --generate-baseline=config/phpstan-baseline.neon"
6965
},
7066
"scripts-descriptions": {
7167
"ci": "Runs all dynamic and static code checks (i.e. currently, only the static checks).",
7268
"ci:php:fixer": "Checks the code style with PHP CS Fixer.",
73-
"ci:php:sniffer": "Checks the code style with PHP_CodeSniffer.",
7469
"ci:php:stan": "Checks the types with PHPStan.",
7570
"ci:static": "Runs all static code analysis checks for the code.",
7671
"fix:php": "Autofixes all autofixable issues in the PHP code.",
7772
"fix:php:fixer": "Fixes autofixable issues found by PHP CS Fixer.",
78-
"fix:php:sniffer": "Fixes autofixable issues found by PHP_CodeSniffer.",
7973
"phpstand:baseline": "Updates the PHPStan baseline file to match the code."
8074
}
8175
}

‎config/phpcs.xml

-17
This file was deleted.

0 commit comments

Comments
 (0)