Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mode detection on Tegra-based platforms that support NVML #678

Closed
elezar opened this issue Apr 24, 2024 · 3 comments
Closed

Fix mode detection on Tegra-based platforms that support NVML #678

elezar opened this issue Apr 24, 2024 · 3 comments
Assignees
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@elezar
Copy link
Member

elezar commented Apr 24, 2024

When using GFD (or the device plugin) on Tegra-based systems, we do not use NVML to extract device information.

Furthermore, we rely on heuristics to detect the platform we are working on.

We need to update the logic in the device plugin to use NVIDIA/go-nvlib#28 to align with other components. Adding a --mode switch (default: auto) also makes sense to allow users to explicitly override it.

@elezar
Copy link
Member Author

elezar commented Apr 24, 2024

This should be addressed by #673

@elezar elezar self-assigned this Apr 24, 2024
Copy link

This issue is stale because it has been open 90 days with no activity. This issue will be closed in 30 days unless new comments are made or the stale label is removed.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 24, 2024
Copy link

This issue was automatically closed due to inactivity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

1 participant