Skip to content

Commit efee069

Browse files
committed
Obsolete unused module types
These were deprecated in R, which has now branched, and there aren't any users on master. Test: build-aosp_crosshatch.ninja is identical Test: treehugger Change-Id: I6286880e45c0facbae56f9a16e8cfcbde12f121c
1 parent 58634e1 commit efee069

16 files changed

+16
-232
lines changed

Diff for: Deprecation.md

+7-7
Original file line numberDiff line numberDiff line change
@@ -18,17 +18,17 @@ have any problems converting, please contact us via:
1818
| `BUILD_AUX_STATIC_LIBRARY` | Obsolete |
1919
| `BUILD_COPY_HEADERS` | Error |
2020
| `BUILD_HOST_EXECUTABLE` | Error |
21-
| `BUILD_HOST_FUZZ_TEST` | Error |
22-
| `BUILD_HOST_NATIVE_TEST` | Error |
21+
| `BUILD_HOST_FUZZ_TEST` | Obsolete |
22+
| `BUILD_HOST_NATIVE_TEST` | Obsolete |
2323
| `BUILD_HOST_SHARED_LIBRARY` | Error |
2424
| `BUILD_HOST_SHARED_TEST_LIBRARY` | Obsolete |
2525
| `BUILD_HOST_STATIC_LIBRARY` | Error |
26-
| `BUILD_HOST_STATIC_TEST_LIBRARY` | Error |
27-
| `BUILD_HOST_TEST_CONFIG` | Error |
28-
| `BUILD_NATIVE_BENCHMARK` | Error |
26+
| `BUILD_HOST_STATIC_TEST_LIBRARY` | Obsolete |
27+
| `BUILD_HOST_TEST_CONFIG` | Obsolete |
28+
| `BUILD_NATIVE_BENCHMARK` | Obsolete |
2929
| `BUILD_SHARED_TEST_LIBRARY` | Obsolete |
30-
| `BUILD_STATIC_TEST_LIBRARY` | Error |
31-
| `BUILD_TARGET_TEST_CONFIG` | Error |
30+
| `BUILD_STATIC_TEST_LIBRARY` | Obsolete |
31+
| `BUILD_TARGET_TEST_CONFIG` | Obsolete |
3232
| `BUILD_*` | Available |
3333

3434
## Module Type Deprecation Process

Diff for: core/clear_vars.mk

-1
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,6 @@ LOCAL_STRIP_MODULE:=
293293
LOCAL_SYSTEM_SHARED_LIBRARIES:=none
294294
LOCAL_TARGET_REQUIRED_MODULES:=
295295
LOCAL_TEST_CONFIG:=
296-
LOCAL_TEST_CONFIG_OPTIONS:=
297296
LOCAL_TEST_DATA:=
298297
LOCAL_TEST_MODULE_TO_PROGUARD_WITH:=
299298
LOCAL_TIDY:=

Diff for: core/config.mk

+1-11
Original file line numberDiff line numberDiff line change
@@ -134,6 +134,7 @@ $(KATI_obsolete_var \
134134
LOCAL_CUSTOM_BUILD_STEP_OUTPUT \
135135
LOCAL_IS_AUX_MODULE \
136136
,AUX support has been removed)
137+
$(KATI_obsolete_var HOST_OUT_TEST_CONFIG TARGET_OUT_TEST_CONFIG LOCAL_TEST_CONFIG_OPTIONS)
137138

138139
# Used to force goals to build. Only use for conditionally defined goals.
139140
.PHONY: FORCE
@@ -196,23 +197,12 @@ BUILD_STATIC_JAVA_LIBRARY :=$= $(BUILD_SYSTEM)/static_java_library.mk
196197
BUILD_HOST_JAVA_LIBRARY :=$= $(BUILD_SYSTEM)/host_java_library.mk
197198
BUILD_COPY_HEADERS :=$= $(BUILD_SYSTEM)/copy_headers.mk
198199
BUILD_NATIVE_TEST :=$= $(BUILD_SYSTEM)/native_test.mk
199-
BUILD_NATIVE_BENCHMARK :=$= $(BUILD_SYSTEM)/native_benchmark.mk
200-
BUILD_HOST_NATIVE_TEST :=$= $(BUILD_SYSTEM)/host_native_test.mk
201200
BUILD_FUZZ_TEST :=$= $(BUILD_SYSTEM)/fuzz_test.mk
202-
BUILD_HOST_FUZZ_TEST :=$= $(BUILD_SYSTEM)/host_fuzz_test.mk
203-
204-
BUILD_SHARED_TEST_LIBRARY :=$= $(BUILD_SYSTEM)/shared_test_lib.mk
205-
BUILD_HOST_SHARED_TEST_LIBRARY :=$= $(BUILD_SYSTEM)/host_shared_test_lib.mk
206-
BUILD_STATIC_TEST_LIBRARY :=$= $(BUILD_SYSTEM)/static_test_lib.mk
207-
BUILD_HOST_STATIC_TEST_LIBRARY :=$= $(BUILD_SYSTEM)/host_static_test_lib.mk
208201

209202
BUILD_NOTICE_FILE :=$= $(BUILD_SYSTEM)/notice_files.mk
210203
BUILD_HOST_DALVIK_JAVA_LIBRARY :=$= $(BUILD_SYSTEM)/host_dalvik_java_library.mk
211204
BUILD_HOST_DALVIK_STATIC_JAVA_LIBRARY :=$= $(BUILD_SYSTEM)/host_dalvik_static_java_library.mk
212205

213-
BUILD_HOST_TEST_CONFIG :=$= $(BUILD_SYSTEM)/host_test_config.mk
214-
BUILD_TARGET_TEST_CONFIG :=$= $(BUILD_SYSTEM)/target_test_config.mk
215-
216206
include $(BUILD_SYSTEM)/deprecation.mk
217207

218208
# ###############################################################

Diff for: core/deprecation.mk

+7-7
Original file line numberDiff line numberDiff line change
@@ -31,23 +31,23 @@ DEFAULT_WARNING_BUILD_MODULE_TYPES :=$= \
3131
DEFAULT_ERROR_BUILD_MODULE_TYPES :=$= \
3232
BUILD_COPY_HEADERS \
3333
BUILD_HOST_EXECUTABLE \
34-
BUILD_HOST_FUZZ_TEST \
35-
BUILD_HOST_NATIVE_TEST \
3634
BUILD_HOST_SHARED_LIBRARY \
3735
BUILD_HOST_STATIC_LIBRARY \
38-
BUILD_HOST_STATIC_TEST_LIBRARY \
39-
BUILD_HOST_TEST_CONFIG \
40-
BUILD_NATIVE_BENCHMARK \
41-
BUILD_STATIC_TEST_LIBRARY \
42-
BUILD_TARGET_TEST_CONFIG \
4336

4437
# These are BUILD_* variables that are always errors to reference.
4538
# Setting the BUILD_BROKEN_USES_BUILD_* variables is also an error.
4639
OBSOLETE_BUILD_MODULE_TYPES :=$= \
4740
BUILD_AUX_EXECUTABLE \
4841
BUILD_AUX_STATIC_LIBRARY \
42+
BUILD_HOST_FUZZ_TEST \
43+
BUILD_HOST_NATIVE_TEST \
4944
BUILD_HOST_SHARED_TEST_LIBRARY \
45+
BUILD_HOST_STATIC_TEST_LIBRARY \
46+
BUILD_HOST_TEST_CONFIG \
47+
BUILD_NATIVE_BENCHMARK \
5048
BUILD_SHARED_TEST_LIBRARY \
49+
BUILD_STATIC_TEST_LIBRARY \
50+
BUILD_TARGET_TEST_CONFIG \
5151

5252
$(foreach m,$(OBSOLETE_BUILD_MODULE_TYPES),\
5353
$(KATI_obsolete_var $(m),Please convert to Soong) \

Diff for: core/envsetup.mk

+1-6
Original file line numberDiff line numberDiff line change
@@ -375,9 +375,6 @@ HOST_OUT_COMMON_GEN := $(HOST_COMMON_OUT_ROOT)/gen
375375
HOST_CROSS_OUT_GEN := $(HOST_CROSS_OUT)/gen
376376
.KATI_READONLY := HOST_CROSS_OUT_GEN
377377

378-
HOST_OUT_TEST_CONFIG := $(HOST_OUT)/test_config
379-
.KATI_READONLY := HOST_OUT_TEST_CONFIG
380-
381378
# Out for HOST_2ND_ARCH
382379
$(HOST_2ND_ARCH_VAR_PREFIX)HOST_OUT_INTERMEDIATES := $(HOST_OUT)/obj32
383380
$(HOST_2ND_ARCH_VAR_PREFIX)HOST_OUT_SHARED_LIBRARIES := $(HOST_OUT)/lib
@@ -463,7 +460,6 @@ TARGET_OUT_ETC := $(TARGET_OUT)/etc
463460
TARGET_OUT_NOTICE_FILES := $(TARGET_OUT_INTERMEDIATES)/NOTICE_FILES
464461
TARGET_OUT_FAKE := $(PRODUCT_OUT)/fake_packages
465462
TARGET_OUT_TESTCASES := $(PRODUCT_OUT)/testcases
466-
TARGET_OUT_TEST_CONFIG := $(PRODUCT_OUT)/test_config
467463
.KATI_READONLY := \
468464
TARGET_OUT_EXECUTABLES \
469465
TARGET_OUT_OPTIONAL_EXECUTABLES \
@@ -477,8 +473,7 @@ TARGET_OUT_TEST_CONFIG := $(PRODUCT_OUT)/test_config
477473
TARGET_OUT_ETC \
478474
TARGET_OUT_NOTICE_FILES \
479475
TARGET_OUT_FAKE \
480-
TARGET_OUT_TESTCASES \
481-
TARGET_OUT_TEST_CONFIG
476+
TARGET_OUT_TESTCASES
482477

483478
ifeq ($(SANITIZE_LITE),true)
484479
# When using SANITIZE_LITE, APKs must not be packaged with sanitized libraries, as they will not

Diff for: core/host_fuzz_test.mk

-10
This file was deleted.

Diff for: core/host_native_test.mk

-23
This file was deleted.

Diff for: core/host_shared_test_lib.mk

-1
This file was deleted.

Diff for: core/host_static_test_lib.mk

-9
This file was deleted.

Diff for: core/host_test_config.mk

-25
This file was deleted.

Diff for: core/host_test_internal.mk

-28
This file was deleted.

Diff for: core/native_benchmark.mk

-15
This file was deleted.

Diff for: core/shared_test_lib.mk

-1
This file was deleted.

Diff for: core/static_test_lib.mk

-9
This file was deleted.

Diff for: core/target_test_config.mk

-23
This file was deleted.

Diff for: core/test_config_common.mk

-56
This file was deleted.

0 commit comments

Comments
 (0)