Skip to content

Commit f71c05a

Browse files
committedMar 7, 2020
Remove unused mips workarounds.
This was never really finished, and hasn't been supported for years. Test: treehugger Change-Id: I7668088d1449f33025aaf36fae0817894c84a877
1 parent 074d8e1 commit f71c05a

12 files changed

+10
-162
lines changed
 

‎core/binary.mk

+4-28
Original file line numberDiff line numberDiff line change
@@ -110,19 +110,8 @@ ifneq ($(LOCAL_SDK_VERSION),)
110110
# Make sure we've built the NDK.
111111
my_additional_dependencies += $(SOONG_OUT_DIR)/ndk_base.timestamp
112112

113-
# mips32r6 is not supported by the NDK. No released NDK contains these
114-
# libraries, but the r10 in prebuilts/ndk had a local hack to add them :(
115-
#
116-
# We need to find a real solution to this problem, but until we do just drop
117-
# mips32r6 things back to r10 to get the tree building again.
118-
ifeq (mips32r6,$(TARGET_$(LOCAL_2ND_ARCH_VAR_PREFIX)ARCH_VARIANT))
119-
ifeq ($(LOCAL_NDK_VERSION), current)
120-
LOCAL_NDK_VERSION := r10
121-
endif
122-
endif
123-
124113
my_arch := $(TARGET_$(LOCAL_2ND_ARCH_VAR_PREFIX)ARCH)
125-
ifneq (,$(filter arm64 mips64 x86_64,$(my_arch)))
114+
ifneq (,$(filter arm64 x86_64,$(my_arch)))
126115
my_min_sdk_version := 21
127116
else
128117
my_min_sdk_version := $(MIN_SUPPORTED_SDK_VERSION)
@@ -156,17 +145,11 @@ ifneq ($(LOCAL_SDK_VERSION),)
156145
$(my_built_ndk)/sysroot/usr/include/$(my_ndk_triple) \
157146
$(my_ndk_sysroot)/usr/include \
158147

159-
# x86_64 and and mips64 are both multilib toolchains, so their libraries are
148+
# x86_64 is a multilib toolchain, so their libraries are
160149
# installed in /usr/lib64. Aarch64, on the other hand, is not a multilib
161150
# compiler, so its libraries are in /usr/lib.
162-
#
163-
# Mips32r6 is yet another variation, with libraries installed in libr6.
164-
#
165-
# For the rest, the libraries are installed simply to /usr/lib.
166-
ifneq (,$(filter x86_64 mips64,$(my_arch)))
151+
ifneq (,$(filter x86_64,$(my_arch)))
167152
my_ndk_libdir_name := lib64
168-
else ifeq (mips32r6,$(TARGET_$(LOCAL_2ND_ARCH_VAR_PREFIX)ARCH_VARIANT))
169-
my_ndk_libdir_name := libr6
170153
else
171154
my_ndk_libdir_name := lib
172155
endif
@@ -180,11 +163,7 @@ ifneq ($(LOCAL_SDK_VERSION),)
180163
# hashes (which are much faster!), but shipping to older devices requires
181164
# the old style hash. Fortunately, we can build with both and it'll work
182165
# anywhere.
183-
#
184-
# This is not currently supported on MIPS architectures.
185-
ifeq (,$(filter mips mips64,$(TARGET_$(LOCAL_2ND_ARCH_VAR_PREFIX)ARCH)))
186-
my_ldflags += -Wl,--hash-style=both
187-
endif
166+
my_ldflags += -Wl,--hash-style=both
188167

189168
# We don't want to expose the relocation packer to the NDK just yet.
190169
LOCAL_PACK_MODULE_RELOCATIONS := false
@@ -195,9 +174,6 @@ ifneq ($(LOCAL_SDK_VERSION),)
195174
my_ndk_stl_shared_lib_fullpath :=
196175
my_ndk_stl_static_lib :=
197176
my_cpu_variant := $(TARGET_$(LOCAL_2ND_ARCH_VAR_PREFIX)CPU_ABI)
198-
ifeq (mips32r6,$(TARGET_$(LOCAL_2ND_ARCH_VAR_PREFIX)ARCH_VARIANT))
199-
my_cpu_variant := mips32r6
200-
endif
201177
LOCAL_NDK_STL_VARIANT := $(strip $(LOCAL_NDK_STL_VARIANT))
202178
ifeq (,$(LOCAL_NDK_STL_VARIANT))
203179
LOCAL_NDK_STL_VARIANT := system

‎core/build-system.html

-2
Original file line numberDiff line numberDiff line change
@@ -467,8 +467,6 @@ <h3><a name="platform-specific"/>Platform specific conditionals</h3>
467467
<b>TARGET_ARCH</b><br/>
468468
arm<br/>
469469
arm64<br/>
470-
mips<br/>
471-
mips64<br/>
472470
x86<br/>
473471
x86_64
474472
</td>

‎core/clang/TARGET_mips.mk

-9
This file was deleted.

‎core/clang/TARGET_mips64.mk

-9
This file was deleted.

‎core/combo/TARGET_linux-mips.mk

-44
This file was deleted.

‎core/combo/TARGET_linux-mips64.mk

-44
This file was deleted.

‎core/config_sanitizers.mk

-6
Original file line numberDiff line numberDiff line change
@@ -134,12 +134,6 @@ ifneq ($(filter address,$(my_sanitize)),)
134134
my_sanitize_diag := $(filter-out cfi,$(my_sanitize_diag))
135135
endif
136136

137-
# CFI needs gold linker, and mips toolchain does not have one.
138-
ifneq ($(filter mips mips64,$(TARGET_$(LOCAL_2ND_ARCH_VAR_PREFIX)ARCH)),)
139-
my_sanitize := $(filter-out cfi,$(my_sanitize))
140-
my_sanitize_diag := $(filter-out cfi,$(my_sanitize_diag))
141-
endif
142-
143137
# Disable sanitizers which need the UBSan runtime for host targets.
144138
ifdef LOCAL_IS_HOST_MODULE
145139
my_sanitize := $(filter-out cfi,$(my_sanitize))

‎core/dex_preopt_config.mk

-10
Original file line numberDiff line numberDiff line change
@@ -56,16 +56,6 @@ DEX2OAT_IMAGE_XMX := $(call get-product-default-property,dalvik.vm.image-dex2oat
5656
DEX2OAT_XMS := $(call get-product-default-property,dalvik.vm.dex2oat-Xms)
5757
DEX2OAT_XMX := $(call get-product-default-property,dalvik.vm.dex2oat-Xmx)
5858

59-
ifeq ($(TARGET_ARCH),$(filter $(TARGET_ARCH),mips mips64))
60-
# MIPS specific overrides.
61-
# For MIPS the ART image is loaded at a lower address. This causes issues
62-
# with the image overlapping with memory on the host cross-compiling and
63-
# building the image. We therefore limit the Xmx value. This isn't done
64-
# via a property as we want the larger Xmx value if we're running on a
65-
# MIPS device.
66-
DEX2OAT_XMX := 128m
67-
endif
68-
6959
ifeq ($(WRITE_SOONG_VARIABLES),true)
7060

7161
$(call json_start)

‎core/envsetup.mk

+1-1
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ TARGET_BUILD_APPS ?=
101101

102102
# ---------------------------------------------------------------
103103
# Set up configuration for host machine. We don't do cross-
104-
# compiles except for arm/mips, so the HOST is whatever we are
104+
# compiles except for arm, so the HOST is whatever we are
105105
# running on
106106

107107
# HOST_OS

‎core/java_renderscript.mk

+1-1
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ LOCAL_JNI_SHARED_LIBRARIES += libRSSupportIO
129129
endif
130130

131131
my_arch := $(TARGET_$(LOCAL_2ND_ARCH_VAR_PREFIX)ARCH)
132-
ifneq (,$(filter arm64 mips64 x86_64,$(my_arch)))
132+
ifneq (,$(filter arm64 x86_64,$(my_arch)))
133133
my_min_sdk_version := 21
134134
else
135135
my_min_sdk_version := $(MIN_SUPPORTED_SDK_VERSION)

‎envsetup.sh

+3-7
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ Invoke ". build/envsetup.sh" from your shell to add the following functions to y
88
Selects <product_name> as the product to build, and <build_variant> as the variant to
99
build, and stores those selections in the environment to be read by subsequent
1010
invocations of 'm' etc.
11-
- tapas: tapas [<App1> <App2> ...] [arm|x86|mips|arm64|x86_64|mips64] [eng|userdebug|user]
11+
- tapas: tapas [<App1> <App2> ...] [arm|x86|arm64|x86_64] [eng|userdebug|user]
1212
- croot: Changes directory to the top of the tree, or a subdirectory thereof.
1313
- m: Makes from the top of the tree.
1414
- mm: Builds and installs all of the modules in the current directory, and their
@@ -218,8 +218,6 @@ function setpaths()
218218
arm64) toolchaindir=aarch64/aarch64-linux-android-$targetgccversion/bin;
219219
toolchaindir2=arm/arm-linux-androideabi-$targetgccversion2/bin
220220
;;
221-
mips|mips64) toolchaindir=mips/mips64el-linux-android-$targetgccversion/bin
222-
;;
223221
*)
224222
echo "Can't find toolchain for unknown architecture: $ARCH"
225223
toolchaindir=xxxxxxxxx
@@ -701,10 +699,10 @@ function _lunch()
701699
function tapas()
702700
{
703701
local showHelp="$(echo $* | xargs -n 1 echo | \grep -E '^(help)$' | xargs)"
704-
local arch="$(echo $* | xargs -n 1 echo | \grep -E '^(arm|x86|mips|arm64|x86_64|mips64)$' | xargs)"
702+
local arch="$(echo $* | xargs -n 1 echo | \grep -E '^(arm|x86|arm64|x86_64)$' | xargs)"
705703
local variant="$(echo $* | xargs -n 1 echo | \grep -E '^(user|userdebug|eng)$' | xargs)"
706704
local density="$(echo $* | xargs -n 1 echo | \grep -E '^(ldpi|mdpi|tvdpi|hdpi|xhdpi|xxhdpi|xxxhdpi|alldpi)$' | xargs)"
707-
local apps="$(echo $* | xargs -n 1 echo | \grep -E -v '^(user|userdebug|eng|arm|x86|mips|arm64|x86_64|mips64|ldpi|mdpi|tvdpi|hdpi|xhdpi|xxhdpi|xxxhdpi|alldpi)$' | xargs)"
705+
local apps="$(echo $* | xargs -n 1 echo | \grep -E -v '^(user|userdebug|eng|arm|x86|arm64|x86_64|ldpi|mdpi|tvdpi|hdpi|xhdpi|xxhdpi|xxxhdpi|alldpi)$' | xargs)"
708706

709707
if [ "$showHelp" != "" ]; then
710708
$(gettop)/build/make/tapasHelp.sh
@@ -727,10 +725,8 @@ function tapas()
727725
local product=aosp_arm
728726
case $arch in
729727
x86) product=aosp_x86;;
730-
mips) product=aosp_mips;;
731728
arm64) product=aosp_arm64;;
732729
x86_64) product=aosp_x86_64;;
733-
mips64) product=aosp_mips64;;
734730
esac
735731
if [ -z "$variant" ]; then
736732
variant=eng

‎tapasHelp.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ SCRIPT_DIR="${PWD}"
66
cd ../..
77
TOP="${PWD}"
88

9-
message='usage: tapas [<App1> <App2> ...] [arm|x86|mips|arm64|x86_64|mips64] [eng|userdebug|user]
9+
message='usage: tapas [<App1> <App2> ...] [arm|x86|arm64|x86_64] [eng|userdebug|user]
1010
1111
tapas selects individual apps to be built by the Android build system. Unlike
1212
"lunch", "tapas" does not request the building of images for a device.

0 commit comments

Comments
 (0)
Please sign in to comment.