Skip to content

Commit 53746d9

Browse files
committed
Optimize docker files layout
1 parent 7c244e3 commit 53746d9

9 files changed

+21
-36
lines changed

.github/workflows/test.yaml

+6-2
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,13 @@ jobs:
1313
name: Test
1414
runs-on: ubuntu-latest
1515
steps:
16-
- uses: actions/checkout@v3
16+
- uses: actions/checkout@v4
1717
with:
1818
fetch-depth: 0
19+
- run: |
20+
docker-compose up -d minio db redis &&
21+
docker-compose up -d cworker conductor &&
22+
docker-compose up minio-prepare
1923
- uses: actions/setup-go@v3
2024
with:
2125
go-version: '1.20.x'
@@ -24,4 +28,4 @@ jobs:
2428
uses: FedericoCarboni/setup-ffmpeg@v1-beta
2529
id: setup-ffmpeg
2630
- name: Run tests
27-
run: make test
31+
run: go test -covermode=count -coverprofile=coverage.out ./...

Dockerfile.test

-25
This file was deleted.

Makefile

+3-3
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,10 @@ transcoder: $(BUILD_DIR)/$(GOOS)_$(GOARCH)/transcoder
1616
./pkg/conductor/cmd/
1717

1818
conductor_image:
19-
docker buildx build -f Dockerfile-conductor -t odyseeteam/transcoder-conductor:$(TRANSCODER_VERSION) --platform linux/amd64 .
19+
docker buildx build -f docker/Dockerfile-conductor -t odyseeteam/transcoder-conductor:$(TRANSCODER_VERSION) --platform linux/amd64 .
2020

2121
cworker_image:
22-
docker buildx build -f Dockerfile-cworker -t odyseeteam/transcoder-cworker:$(TRANSCODER_VERSION) --platform linux/amd64 .
22+
docker buildx build -f docker/Dockerfile-cworker -t odyseeteam/transcoder-cworker:$(TRANSCODER_VERSION) --platform linux/amd64 .
2323

2424
test_down:
2525
docker-compose down
@@ -30,7 +30,7 @@ test_prepare:
3030
docker-compose up minio-prepare
3131

3232
test: test_prepare
33-
go test -exclude="docker-data" -covermode=count -coverprofile=coverage.out ./...
33+
go test -covermode=count -coverprofile=coverage.out ./...
3434

3535
towerz:
3636
docker run --rm -v "$(PWD)":/usr/src/transcoder -w /usr/src/transcoder --platform linux/amd64 golang:1.16.10 make tower

docker-compose.yml

+12-6
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ services:
1515
- "8080:8080"
1616
# build:
1717
# context: .
18-
# dockerfile: Dockerfile-tower
18+
# dockerfile: docker/Dockerfile-tower
1919
depends_on:
2020
- redis
2121
- db
@@ -35,7 +35,7 @@ services:
3535
- --blob-server=blobcache-eu.lbry.com
3636
# build:
3737
# context: .
38-
# dockerfile: Dockerfile-worker
38+
# dockerfile: docker/Dockerfile-worker
3939
depends_on: ["redis"]
4040
volumes:
4141
- ${PWD}/worker.ex.yml:/app/worker.yml
@@ -52,7 +52,7 @@ services:
5252
ports:
5353
- '6379:6379'
5454
volumes:
55-
- ./docker-data/redis:/data
55+
- redis-data:/data
5656
command: >
5757
--requirepass odyredis --appendonly yes
5858
labels:
@@ -66,7 +66,7 @@ services:
6666
environment:
6767
POSTGRES_PASSWORD: odyseeteam
6868
volumes:
69-
- ./docker-data/postgres:/var/lib/postgresql/data
69+
- db-data:/var/lib/postgresql/data
7070
command:
7171
- -clogging_collector=on
7272
- -clog_statement=all
@@ -84,15 +84,15 @@ services:
8484
- "38861:38861"
8585
- "41949:41949"
8686
volumes:
87-
- ./docker-data/minio:/data
87+
- minio-data:/data
8888
environment:
8989
MINIO_ROOT_USER: ody
9090
MINIO_ROOT_PASSWORD: odyseetes3
9191
command: server --address 0.0.0.0:9000 /data
9292
minio-prepare:
9393
image: minio/mc
9494
volumes:
95-
- ./docker-data/minio:/data
95+
- minio-data:/data
9696
entrypoint: >
9797
/bin/sh -c "
9898
/usr/bin/mc config host add myminio http://minio:9000 ody odyseetes3;
@@ -102,3 +102,9 @@ services:
102102
exit 0;
103103
"
104104
depends_on: ["minio"]
105+
106+
volumes:
107+
108+
db-data:
109+
minio-data:
110+
redis-data:
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.

0 commit comments

Comments
 (0)