Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: In-App not displaying when trigger is set for once #2269

Open
1 task done
binay-shaw-ionage opened this issue Mar 7, 2025 · 3 comments
Open
1 task done

[Bug]: In-App not displaying when trigger is set for once #2269

binay-shaw-ionage opened this issue Mar 7, 2025 · 3 comments

Comments

@binay-shaw-ionage
Copy link

binay-shaw-ionage commented Mar 7, 2025

What happened?

My Android app uses the latest version of OneSignal. I currently implemented OneSignal for In-App messaging.
Keeping the key: is_user_signed_in with value true, it should trigger the in-app.

FYI, this code was called from LauncedEffect(Unit), i.e. everytime the screen is opened.
To avoid multiple triggers, I used a global boolean flag: var hasShownInAppMessaging: Boolean = false
This allowed me to trigger In-App once per session.
Schedule is set to: Every time trigger conditions are satisfied

Image

But this didn't worked as expected.

When it actually got triggered?

  • First time
  • On Logout and Login (considering the trigger is for users when signed in)

The log says OperationRepo: execute response = SUCCESS with GOT Response

Steps to reproduce?

1. Install using version `5.1.29`
2. Trigger OneSignal with a Key-Value pair
3. Create boolean flag = false
4. This trigger should be in `LaunchedEffect(Unit) {...}`
5. Inside the block, check if boolean flag = true, return if yes.
6. Trigger for the OneSignal In-App
4. Set a boolean flag = true for first time trigger

What did you expect to happen?

I expected the app to trigger In-App only at Screen X, where it is triggered using is_user_signed_in with value true
This In-App should be triggered once per launch.

OneSignal Android SDK version

5.1.29

Android version

14

Specific Android models

Relevant log output

[main] Retrieving service interface com.onesignal.inAppMessages.IInAppMessagesManager
[main] Already instantiated: com.onesignal.inAppMessages.internal.InAppMessagesManager@6953c85
[main] InAppMessagesManager.addTrigger(key: is_user_signed_in, value: true)
[main] InAppMessagesManager.onTriggerChanged(newTriggerKey: is_user_signed_in)
[DefaultDispatcher-worker-15] HttpClient: Got Response = GET
[OpRepo] OperationRepo: execute response = SUCCESS
[OpRepo] retryAfterSeconds: null

Code of Conduct

  • I agree to follow this project's Code of Conduct
@nan-li
Copy link
Contributor

nan-li commented Mar 7, 2025

Hi @binay-shaw-ionage, I don't understand your question.

I expected the app to trigger In-App only at Screen X, where it is triggered using is_user_signed_in with value true
This In-App should be triggered once per launch.

Anytime you call OneSignal.InAppMessages.addTrigger(key: is_user_signed_in, value: true), the in-app message will display.

@binay-shaw-ionage
Copy link
Author

binay-shaw-ionage commented Mar 10, 2025

@nan-li Yes. I understand the addTrigger(...) code where it shows in-app whenever triggered.
My objective is to show it only one time per app launch. (Not in Splash or Auth Screen but trigger in Home Screen)

Triggering it in Home Screen caused to trigger it multiple times whenever the screen is launched.
So, for now my objective is to restrict it triggering multiple times and only trigger one time per app launch.

What I tried?
I tried creating a boolean flag to set true once the trigger is invoked. And the second time it returns without any changes or re-trigger.

Did it worked?
No.

On what cases it worked?

  • App launch (First time). On relaunch it did not worked as expected but logged that it triggered it.
  • Re-login (Home Screen -> Auth -> Home Screen) [Trigger logic is in Home Screen, and boolean flag is in host Activity.]

FYI: It's happening the same for both Android and iOS

@binay-shaw-ionage
Copy link
Author

I also see shouldDisplayAgain to show when the in-app appears.
When in-app is not triggered, shouldDisplayAgain is not in the log as well.

FYI: shouldDisplayAgain is a part of OneSignal log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants