Skip to content

Commit ef6c3f2

Browse files
authored
Migrate from Log4j 1.2.x to Logback (#307)
Log4j 1.x has been EOL for several years.
1 parent d2a96f1 commit ef6c3f2

File tree

5 files changed

+20
-13
lines changed

5 files changed

+20
-13
lines changed

cli/pom.xml

+2-2
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@
3131
<artifactId>slf4j-api</artifactId>
3232
</dependency>
3333
<dependency>
34-
<groupId>org.slf4j</groupId>
35-
<artifactId>slf4j-log4j12</artifactId>
34+
<groupId>ch.qos.logback</groupId>
35+
<artifactId>logback-classic</artifactId>
3636
</dependency>
3737
</dependencies>
3838
<build>

cli/src/main/java/org/openapitools/openapidiff/cli/Main.java

+4-3
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package org.openapitools.openapidiff.cli;
22

3+
import ch.qos.logback.classic.Level;
34
import io.swagger.v3.parser.core.models.AuthorizationValue;
45
import java.io.File;
56
import java.io.IOException;
@@ -15,8 +16,6 @@
1516
import org.apache.commons.cli.ParseException;
1617
import org.apache.commons.io.FileUtils;
1718
import org.apache.commons.lang3.exception.ExceptionUtils;
18-
import org.apache.log4j.Level;
19-
import org.apache.log4j.LogManager;
2019
import org.openapitools.openapidiff.core.OpenApiCompare;
2120
import org.openapitools.openapidiff.core.model.ChangedOpenApi;
2221
import org.openapitools.openapidiff.core.output.ConsoleRender;
@@ -157,7 +156,9 @@ public static void main(String... args) {
157156
if (line.hasOption("state")) {
158157
logLevel = "OFF";
159158
}
160-
LogManager.getRootLogger().setLevel(Level.toLevel(logLevel));
159+
ch.qos.logback.classic.Logger root =
160+
(ch.qos.logback.classic.Logger) LoggerFactory.getLogger(Logger.ROOT_LOGGER_NAME);
161+
root.setLevel(Level.toLevel(logLevel));
161162

162163
if (line.getArgList().size() < 2) {
163164
throw new ParseException("Missing arguments");

cli/src/main/resources/log4j.properties

-5
This file was deleted.

cli/src/main/resources/logback.xml

+11
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
<configuration>
2+
<appender name="STDOUT" class="ch.qos.logback.core.ConsoleAppender">
3+
<encoder>
4+
<pattern>[%thread] %-5level %logger{36} - %msg%n</pattern>
5+
</encoder>
6+
</appender>
7+
8+
<root level="debug">
9+
<appender-ref ref="STDOUT"/>
10+
</root>
11+
</configuration>

pom.xml

+3-3
Original file line numberDiff line numberDiff line change
@@ -142,9 +142,9 @@
142142
<version>${slf4j.version}</version>
143143
</dependency>
144144
<dependency>
145-
<groupId>org.slf4j</groupId>
146-
<artifactId>slf4j-log4j12</artifactId>
147-
<version>${slf4j.version}</version>
145+
<groupId>ch.qos.logback</groupId>
146+
<artifactId>logback-classic</artifactId>
147+
<version>1.2.10</version>
148148
</dependency>
149149
<dependency>
150150
<groupId>commons-httpclient</groupId>

0 commit comments

Comments
 (0)