Skip to content

Commit 25dc54f

Browse files
author
Dibik
committed
G2P-2555: Test cases resolved
1 parent 379daae commit 25dc54f

File tree

3 files changed

+42
-6
lines changed

3 files changed

+42
-6
lines changed

g2p_registry_base/tests/test_reg_id.py

+30-4
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,13 @@ def test_01_display_name(self):
1616
id_type = self.id_type_model.create({"name": "Test ID Type", "id_validation": "[0-9]+"})
1717

1818
reg_id = self.reg_id_model.create(
19-
{"partner_id": partner.id, "id_type": id_type.id, "value": "123456" ,"status":"valid", "description":"Due to API"}
19+
{
20+
"partner_id": partner.id,
21+
"id_type": id_type.id,
22+
"value": "123456",
23+
"status": "valid",
24+
"description": "Due to API",
25+
}
2026
)
2127

2228
# Call the _compute_display_name method
@@ -35,7 +41,13 @@ def test_02_create_registrant_id(self):
3541
id_type = self.id_type_model.create({"name": "Test ID Type", "id_validation": "[0-9]+"})
3642

3743
reg_id = self.reg_id_model.create(
38-
{"partner_id": partner.id, "id_type": id_type.id, "value": "123456", "status":"valid", "description":"Due to API"}
44+
{
45+
"partner_id": partner.id,
46+
"id_type": id_type.id,
47+
"value": "123456",
48+
"status": "valid",
49+
"description": "Due to API",
50+
}
3951
)
4052
self.assertEqual(reg_id.value, "123456", "Registrant ID value is not as expected.")
4153

@@ -44,15 +56,29 @@ def test_03_invalid_id_value(self):
4456
id_type = self.id_type_model.create({"name": "Test ID Type", "id_validation": "[0-9]+"})
4557

4658
with self.assertRaises(ValidationError) as context:
47-
self.reg_id_model.create({"partner_id": partner.id, "id_type": id_type.id, "value": "abc", "status":"valid", "description":"Due to API"})
59+
self.reg_id_model.create(
60+
{
61+
"partner_id": partner.id,
62+
"id_type": id_type.id,
63+
"value": "abc",
64+
"status": "valid",
65+
"description": "Due to API",
66+
}
67+
)
4868

4969
self.assertIn("The provided Test ID Type ID 'abc' is invalid.", str(context.exception))
5070

5171
def test_04_name_search(self):
5272
partner = self.partner_model.create({"name": "Test Partner", "is_registrant": True})
5373
id_type = self.id_type_model.create({"name": "Test ID Type"})
5474
reg_id = self.reg_id_model.create(
55-
{"partner_id": partner.id, "id_type": id_type.id, "value": "Test Value","status":"valid", "description":"Due to API"}
75+
{
76+
"partner_id": partner.id,
77+
"id_type": id_type.id,
78+
"value": "Test Value",
79+
"status": "valid",
80+
"description": "Due to API",
81+
}
5682
)
5783
search_result = self.reg_id_model._name_search("Test Partner")
5884
self.assertIn(reg_id.id, search_result, "Expected record not found in search result")

g2p_registry_group/tests/test_groups.py

+6-1
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,12 @@ def test_02_add_id(self):
115115
"name": "Testing ID Type",
116116
}
117117
)
118-
vals = {"id_type": id_type.id, "value": "112233445566778899"}
118+
vals = {
119+
"id_type": id_type.id,
120+
"value": "112233445566778899",
121+
"status": "valid",
122+
"description": "Due to API",
123+
}
119124

120125
self.group_1.write({"reg_ids": [(0, 0, vals)]})
121126
expected_value = "112233445566778899"

g2p_registry_individual/tests/test_individuals.py

+6-1
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,12 @@ def test_04_add_id(self):
139139
"name": "Testing ID Type",
140140
}
141141
)
142-
vals = {"id_type": id_type.id, "value": "112233445566778899"}
142+
vals = {
143+
"id_type": id_type.id,
144+
"value": "112233445566778899",
145+
"status": "valid",
146+
"description": "Due to API",
147+
}
143148

144149
self.registrant_1.write({"reg_ids": [(0, 0, vals)]})
145150
expected_value = "112233445566778899"

0 commit comments

Comments
 (0)