Add tests for wstETH/WETH Balancer pool (#1725)

* Split deployment and fix fixtures

* Deposit tests for wstETH/WETH pool

* Add withdraw test

Author: shahthepro

contracts/contracts/proxies/Proxies.sol

@@ -165,3 +165,12 @@ contract OETHBalancerMetaPoolrEthStrategyProxy is
 {
 
 }
+
+/**
+ * @notice OETHBalancerMetaPoolwstEthStrategyProxy delegates calls to a BalancerMetaPoolStrategy implementation
+ */
+contract OETHBalancerMetaPoolwstEthStrategyProxy is
+    InitializeGovernedUpgradeabilityProxy
+{
+
+}

contracts/contracts/strategies/balancer/BaseBalancerStrategy.sol

@@ -287,10 +287,14 @@ abstract contract BaseBalancerStrategy is InitializableAbstractStrategy {
     {
         if (asset == stETH) {
             wrappedAsset = wstETH;
-            wrappedAmount = IWstETH(wstETH).wrap(amount);
+            if (amount > 0) {
+                wrappedAmount = IWstETH(wstETH).wrap(amount);
+            }
         } else if (asset == frxETH) {
             wrappedAsset = sfrxETH;
-            wrappedAmount = IERC4626(sfrxETH).deposit(amount, address(this));
+            if (amount > 0) {
+                wrappedAmount = IERC4626(sfrxETH).deposit(amount, address(this));
+            }
         } else {
             wrappedAsset = asset;
             wrappedAmount = amount;

contracts/test/_fixture.js

@@ -3,7 +3,7 @@ const hre = require("hardhat");
 const { ethers } = hre;
 
 const addresses = require("../utils/addresses");
-const { balancer_rETH_WETH_PID } = require("../utils/constants");
+const { balancer_rETH_WETH_PID, balancer_stETH_WETH_PID } = require("../utils/constants");
 const {
   fundAccounts,
   fundAccountsForOETHUnitTests,
@@ -27,6 +27,7 @@ const threepoolSwapAbi = require("./abi/threepoolSwap.json");
 const sfrxETHAbi = require("./abi/sfrxETH.json");
 const { deployWithConfirmation } = require("../utils/deploy");
 const { defaultAbiCoder, parseUnits, parseEther } = require("ethers/lib/utils");
+const balancerStrategyDeployment = require("../utils/balancerStrategyDeployment");
 
 const defaultFixture = deployments.createFixture(async () => {
   await deployments.fixture(
@@ -828,34 +829,95 @@ async function convexVaultFixture() {
 }
 
 /**
- * Configure a Vault with only the balancerREthStrategy
+ * Configure a Vault with the balancerREthStrategy
  */
-async function balancerREthFixture() {
-  const fixture = await loadFixture(defaultFixture);
-  const { oethVault, timelock, weth, reth, balancerREthStrategy, josh } =
-    fixture;
+function balancerREthFixtureSetup() {
+  return deployments.createFixture(async () => {
+    const fixture = await defaultFixture();
+    const { oethVault, timelock, weth, reth, balancerREthStrategy, josh } =
+      fixture;
 
-  await oethVault
-    .connect(timelock)
-    .setAssetDefaultStrategy(reth.address, balancerREthStrategy.address);
-  await oethVault
-    .connect(timelock)
-    .setAssetDefaultStrategy(weth.address, balancerREthStrategy.address);
+    await oethVault
+      .connect(timelock)
+      .setAssetDefaultStrategy(reth.address, balancerREthStrategy.address);
+    await oethVault
+      .connect(timelock)
+      .setAssetDefaultStrategy(weth.address, balancerREthStrategy.address);
 
-  fixture.rEthBPT = await ethers.getContractAt(
-    "IERC20Metadata",
-    addresses.mainnet.rETH_WETH_BPT,
-    josh
-  );
-  fixture.balancerREthPID = balancer_rETH_WETH_PID;
+    fixture.rEthBPT = await ethers.getContractAt(
+      "IERC20Metadata",
+      addresses.mainnet.rETH_WETH_BPT,
+      josh
+    );
+    fixture.balancerREthPID = balancer_rETH_WETH_PID;
 
-  fixture.balancerVault = await ethers.getContractAt(
-    "IBalancerVault",
-    addresses.mainnet.balancerVault,
-    josh
-  );
+    fixture.balancerVault = await ethers.getContractAt(
+      "IBalancerVault",
+      addresses.mainnet.balancerVault,
+      josh
+    );
 
-  return fixture;
+    return fixture;
+  })
+}
+
+/**
+ * Configure a Vault with the balancer strategy for wstETH/WETH pool
+ */
+function balancerWstEthFixtureSetup() {
+  return deployments.createFixture(async () => {
+    const fixture = await defaultFixture();
+
+    const d = balancerStrategyDeployment({
+      deploymentOpts: {
+        deployName: "99999_balancer_wstETH_WETH",
+        forceDeploy: true,
+        deployerIsProposer: true,
+      },
+      proxyContractName: "OETHBalancerMetaPoolwstEthStrategyProxy",
+    
+      platformAddress: addresses.mainnet.wstETH_WETH_BPT,
+      poolId: balancer_stETH_WETH_PID,
+    
+      auraRewardsContractAddress: addresses.mainnet.wstETH_WETH_AuraRewards,
+    
+      rewardTokenAddresses: [addresses.mainnet.BAL, addresses.mainnet.AURA],
+      assets: [addresses.mainnet.stETH, addresses.mainnet.WETH],
+    })
+
+    await d(hre)
+
+
+    const balancerWstEthStrategyProxy = await ethers.getContract("OETHBalancerMetaPoolwstEthStrategyProxy")
+    const balancerWstEthStrategy = await ethers.getContractAt("BalancerMetaPoolStrategy", balancerWstEthStrategyProxy.address)
+
+    fixture.balancerWstEthStrategy = balancerWstEthStrategy
+
+    const { oethVault, timelock, weth, stETH, josh } =
+      fixture;
+
+    await oethVault
+      .connect(timelock)
+      .setAssetDefaultStrategy(stETH.address, balancerWstEthStrategy.address);
+    await oethVault
+      .connect(timelock)
+      .setAssetDefaultStrategy(weth.address, balancerWstEthStrategy.address);
+
+    fixture.stEthBPT = await ethers.getContractAt(
+      "IERC20Metadata",
+      addresses.mainnet.wstETH_WETH_BPT,
+      josh
+    );
+    fixture.balancerWstEthPID = balancer_stETH_WETH_PID;
+
+    fixture.balancerVault = await ethers.getContractAt(
+      "IBalancerVault",
+      addresses.mainnet.balancerVault,
+      josh
+    );
+
+    return fixture;
+  })
 }
 
 async function fundWith3Crv(address, maxAmount) {
@@ -1656,7 +1718,8 @@ module.exports = {
   impersonateAndFundContract,
   impersonateAccount,
   fraxETHStrategyFixtureSetup,
-  balancerREthFixture,
+  balancerREthFixtureSetup,
+  balancerWstEthFixtureSetup,
   oethMorphoAaveFixtureSetup,
   mintWETH,
   replaceContractAt,