Update tests with exceptions to match

Author: Ayesh

src/PdoMysql.php

@@ -2,11 +2,8 @@
 class PdoMysql extends PDO {
 
     public const ATTR_USE_BUFFERED_QUERY = PDO::MYSQL_ATTR_USE_BUFFERED_QUERY;
-
-    /** @cvalue PDO_MYSQL_ATTR_LOCAL_INFILE */
     public const ATTR_LOCAL_INFILE = PDO::MYSQL_ATTR_LOCAL_INFILE;
 
-    /** @cvalue PDO_MYSQL_ATTR_INIT_COMMAND */
     public const ATTR_INIT_COMMAND = PDO::MYSQL_ATTR_INIT_COMMAND;
 
 #ifndef PDO_USE_MYSQLND
@@ -20,54 +17,52 @@ class PdoMysql extends PDO {
     #public const int ATTR_READ_DEFAULT_GROUP = UNKNOWN;
 #endif
 
-    /** @cvalue PDO_MYSQL_ATTR_COMPRESS */
     public const ATTR_COMPRESS = PDO::MYSQL_ATTR_COMPRESS;
 
-    /** @cvalue PDO_MYSQL_ATTR_DIRECT_QUERY */
     public const ATTR_DIRECT_QUERY = PDO::MYSQL_ATTR_DIRECT_QUERY;
 
-    /** @cvalue PDO_MYSQL_ATTR_FOUND_ROWS */
     public const ATTR_FOUND_ROWS = PDO::MYSQL_ATTR_FOUND_ROWS;
 
-    /** @cvalue PDO_MYSQL_ATTR_IGNORE_SPACE */
     public const ATTR_IGNORE_SPACE = PDO::MYSQL_ATTR_IGNORE_SPACE;
 
-    /** @cvalue PDO_MYSQL_ATTR_SSL_KEY */
     public const ATTR_SSL_KEY = PDO::MYSQL_ATTR_SSL_KEY;
 
-    /** @cvalue PDO_MYSQL_ATTR_SSL_CERT */
     public const ATTR_SSL_CERT = PDO::MYSQL_ATTR_SSL_CERT;
 
-    /** @cvalue PDO_MYSQL_ATTR_SSL_CA */
     public const ATTR_SSL_CA = PDO::MYSQL_ATTR_SSL_CA;
 
-    /** @cvalue PDO_MYSQL_ATTR_SSL_CAPATH */
     public const ATTR_SSL_CAPATH = PDO::MYSQL_ATTR_SSL_CAPATH;
 
-    /** @cvalue PDO_MYSQL_ATTR_SSL_CIPHER */
     public const ATTR_SSL_CIPHER = PDO::MYSQL_ATTR_SSL_CIPHER;
 
-#if MYSQL_VERSION_ID > 50605 || defined(PDO_USE_MYSQLND)
-    /** @cvalue PDO_MYSQL_ATTR_SERVER_PUBLIC_KEY */
     public const ATTR_SERVER_PUBLIC_KEY = PDO::MYSQL_ATTR_SERVER_PUBLIC_KEY;
-#endif
-
-    /** @cvalue PDO_MYSQL_ATTR_MULTI_STATEMENTS */
     public const ATTR_MULTI_STATEMENTS = PDO::MYSQL_ATTR_MULTI_STATEMENTS;
 
-    /** @cvalue PDO_MYSQL_ATTR_SSL_VERIFY_SERVER_CERT */
     public const ATTR_SSL_VERIFY_SERVER_CERT = PDO::MYSQL_ATTR_SSL_VERIFY_SERVER_CERT;
 
-#if MYSQL_VERSION_ID >= 80021 || defined(PDO_USE_MYSQLND)
-    /** @cvalue PDO_MYSQL_ATTR_LOCAL_INFILE_DIRECTORY */
     public const ATTR_LOCAL_INFILE_DIRECTORY = PDO::MYSQL_ATTR_LOCAL_INFILE_DIRECTORY;
-#endif
     public static function connect(
         string $dsn,
         ?string $username = null,
         #[\SensitiveParameter] ?string $password = null,
         ?array $options = null
     ): static {
+
+        if (!preg_match('/^([a-z0-9]+):/', $dsn, $matches)) {
+            throw new PDOException('PDO::connect(): Argument #1 ($dsn) must be a valid data source name.');
+        }
+
+        if (!in_array($matches[1], PDO::getAvailableDrivers(), true)) {
+            throw new PDOException('Count not find driver');
+        }
+
+        if ($matches[1] !== 'mysql') {
+            throw new PDOException(sprintf('PdoMysql::connect() cannot be called when connecting to the "%s" driver, either %s::connect() or PDO::connect() must be called instead.',
+                $matches[1],
+                ucwords($matches[1]),
+            ));
+        }
+
         return new static($dsn, $username, $password, $options);
     }
 }

tests/PdoMysqlTest.php

@@ -26,4 +26,20 @@ public function testPdoConstantsSameAsPdoMysql(string $constant, string $mysqlCo
         $this->assertTrue(defined(PdoMysql::class . '::' . $mysqlConstant), 'Check if PdoMysql::' . $mysqlConstant . ' exists');
         $this->assertSame(constant('PDO::' . $constant), constant(PdoMysql::class . '::' . $mysqlConstant), 'Check if value and type PDO::' . $constant . ' === ' . PdoMysql::class . '::' . $mysqlConstant);
     }
+
+    public function testThrowsOnDifferentDsns(): void {
+        $this->expectException(PDOException::class);
+        $this->expectExceptionMessage('could not find driver');
+        PdoMysql::connect('foobar:test');
+    }
+
+    public function testThrowsOnUnknownDsns(): void {
+        if (!in_array('sqlite', PDO::getAvailableDrivers(), true)) {
+            $this->markTestSkipped('Sqlite driver not available');
+        }
+
+        $this->expectException(PDOException::class);
+        $this->expectExceptionMessage('PdoMysql::connect() cannot be called when connecting to the "sqlite" driver, either PdoSqlite::connect() or PDO::connect() must be called instead');
+        PdoMysql::connect('sqlite:test');
+    }
 }