【Hackathon 6th Fundable Projects 2 No.12】clang-analyzer-cplusplus.NewDeleteLeaks-final (#64600)

* 5.26

* 5.26

* 5.26

* 5.26

* 5.26

* 5.26

* 5.26

* 5.26

* 5.26

Author: ApricityXX

.clang-tidy

@@ -70,7 +70,7 @@ clang-analyzer-core.uninitialized.Assign,
 clang-analyzer-cplusplus.InnerPointer,
 -clang-analyzer-cplusplus.Move,
 -clang-analyzer-cplusplus.NewDelete,
--clang-analyzer-cplusplus.NewDeleteLeaks,
+clang-analyzer-cplusplus.NewDeleteLeaks,
 -clang-analyzer-cplusplus.PureVirtualCall,
 -clang-analyzer-cplusplus.SelfAssignment,
 -clang-analyzer-cplusplus.SmartPtr,

paddle/fluid/platform/enforce_test.cc

@@ -596,6 +596,7 @@ TEST(enforce, cannot_to_string_type) {
 TEST(GET_DATA_SAFELY_MACRO, SUCCESS) {
   int* a = new int(10);  // NOLINT
   GET_DATA_SAFELY(a, "Input", "X", "dummy");
+  delete a;
 }
 
 TEST(GET_DATA_SAFELY_MACRO, FAIL) {

paddle/pir/src/core/op_info_impl.cc

@@ -72,28 +72,34 @@ OpInfo OpInfoImpl::Create(Dialect *dialect,
            << " interfaces, " << traits_num << " traits, " << attributes_num
            << " attributes.";
   size_t base_size = sizeof(TypeId) * traits_num + sizeof(OpInfoImpl);
-  char *base_ptr = static_cast<char *>(::operator new(base_size));
+  std::unique_ptr<char[]> base_ptr(new char[base_size]);
   VLOG(10) << "Malloc " << base_size << " Bytes at "
-           << static_cast<void *>(base_ptr);
+           << static_cast<void *>(base_ptr.get());
+
+  char *raw_base_ptr = base_ptr.get();
   if (traits_num > 0) {
-    auto p_first_trait = reinterpret_cast<TypeId *>(base_ptr);
-    memcpy(base_ptr, trait_set.data(), sizeof(TypeId) * traits_num);
+    auto p_first_trait = reinterpret_cast<TypeId *>(raw_base_ptr);
+    memcpy(raw_base_ptr, trait_set.data(), sizeof(TypeId) * traits_num);
     std::sort(p_first_trait, p_first_trait + traits_num);
-    base_ptr += traits_num * sizeof(TypeId);
+    raw_base_ptr += traits_num * sizeof(TypeId);
   }
+
   // Construct OpInfoImpl.
-  VLOG(10) << "Construct OpInfoImpl at " << reinterpret_cast<void *>(base_ptr)
-           << " ......";
-  OpInfo op_info = OpInfo(new (base_ptr) OpInfoImpl(std::move(interface_set),
-                                                    dialect,
-                                                    op_id,
-                                                    op_name,
-                                                    traits_num,
-                                                    attributes_num,
-                                                    attributes_name,
-                                                    verify_sig,
-                                                    verify_region));
-  return op_info;
+  VLOG(10) << "Construct OpInfoImpl at "
+           << reinterpret_cast<void *>(raw_base_ptr) << " ......";
+  OpInfoImpl *impl = new (raw_base_ptr) OpInfoImpl(std::move(interface_set),
+                                                   dialect,
+                                                   op_id,
+                                                   op_name,
+                                                   traits_num,
+                                                   attributes_num,
+                                                   attributes_name,
+                                                   verify_sig,
+                                                   verify_region);
+
+  // Release the unique_ptr ownership after successful construction
+  base_ptr.release();
+  return OpInfo(impl);
 }
 void OpInfoImpl::Destroy(OpInfo info) {
   if (info.impl_) {