Skip to content

Commit 5f3a6c7

Browse files
authored
Remove unused interface, set LayoutManager in layout #43 from GeorgCantor/master
Removed unused interface, set LayoutManager in layout
2 parents 99f680a + 0faca8d commit 5f3a6c7

File tree

3 files changed

+4
-12
lines changed

3 files changed

+4
-12
lines changed

app/src/main/java/dev/shreyaspatil/foodium/ui/main/MainActivity.kt

+3-8
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,6 @@ import android.widget.ImageView
3535
import androidx.activity.viewModels
3636
import androidx.appcompat.app.AppCompatDelegate
3737
import androidx.core.app.ActivityOptionsCompat
38-
import androidx.lifecycle.Observer
39-
import androidx.recyclerview.widget.LinearLayoutManager
4038
import com.shreyaspatil.MaterialDialog.MaterialDialog
4139
import dagger.hilt.android.AndroidEntryPoint
4240
import dev.shreyaspatil.foodium.R
@@ -64,10 +62,7 @@ class MainActivity : BaseActivity<MainViewModel, ActivityMainBinding>() {
6462
setContentView(mViewBinding.root)
6563

6664
// Initialize RecyclerView
67-
mViewBinding.postsRecyclerView.apply {
68-
layoutManager = LinearLayoutManager(this@MainActivity)
69-
adapter = mAdapter
70-
}
65+
mViewBinding.postsRecyclerView.adapter = mAdapter
7166

7267
initPosts()
7368

@@ -77,7 +72,7 @@ class MainActivity : BaseActivity<MainViewModel, ActivityMainBinding>() {
7772
private fun initPosts() {
7873
mViewModel.postsLiveData.observe(
7974
this,
80-
Observer { state ->
75+
{ state ->
8176
when (state) {
8277
is State.Loading -> showLoading(true)
8378
is State.Success -> {
@@ -118,7 +113,7 @@ class MainActivity : BaseActivity<MainViewModel, ActivityMainBinding>() {
118113
private fun handleNetworkChanges() {
119114
NetworkUtils.getNetworkLiveData(applicationContext).observe(
120115
this,
121-
Observer { isConnected ->
116+
{ isConnected ->
122117
if (!isConnected) {
123118
mViewBinding.textViewNetworkStatus.text =
124119
getString(R.string.text_no_connectivity)

app/src/main/java/dev/shreyaspatil/foodium/ui/main/adapter/PostListAdapter.kt

-4
Original file line numberDiff line numberDiff line change
@@ -53,10 +53,6 @@ class PostListAdapter(
5353
override fun onBindViewHolder(holder: PostViewHolder, position: Int) =
5454
holder.bind(getItem(position), onItemClicked)
5555

56-
interface OnItemClickListener {
57-
fun onItemClicked(post: Post, imageView: ImageView)
58-
}
59-
6056
companion object {
6157
private val DIFF_CALLBACK = object : DiffUtil.ItemCallback<Post>() {
6258
override fun areItemsTheSame(oldItem: Post, newItem: Post): Boolean =

app/src/main/res/layout/activity_main.xml

+1
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@
5959
style="@style/PostsRecyclerStyle"
6060
android:layout_width="match_parent"
6161
android:layout_height="0dp"
62+
app:layoutManager="androidx.recyclerview.widget.LinearLayoutManager"
6263
app:layout_constraintEnd_toEndOf="parent"
6364
app:layout_constraintStart_toStartOf="parent"
6465
app:layout_constraintTop_toBottomOf="@+id/networkStatusLayout"

0 commit comments

Comments
 (0)