Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document shipping just .nim files #40

Closed
juancarlospaco opened this issue Feb 14, 2021 · 7 comments
Closed

Document shipping just .nim files #40

juancarlospaco opened this issue Feb 14, 2021 · 7 comments

Comments

@juancarlospaco
Copy link
Contributor

juancarlospaco commented Feb 14, 2021

I am interested in trying all ways of shipping that nimporter can do, one of the options is not documented along with the others,
thats the option of just shipping the .nim files, I made a PIP package that install Nim and other that can install Nimpy,
so would be nice to document on the readme how users can package the .nim files.
For new users it might not be so obvious.

You can make your package depend on it install_requires = ["choosenim_install"], heres an example on Windows:

windows-compile

Commands in order to copy & paste:

  • pip install choosenim_install
  • pip install nimble_install --install-option="--nimble=nimpy"

Feel free to use the screenshot if is useful for Docs.
:)

@Pebaz
Copy link
Owner

Pebaz commented Feb 14, 2021

Hello @juancarlospaco !

I am interested in using choosenim_install as a dependency, but I wanted to ask: what does it do if Nim is already installed on the target machine?

Also, I forgot that this was in the readme, but here are the instructions for bundling just the Nim files. Using this method depends on having the Nim compiler installed on the target machine, which is why I'd like to know what the choosenim_install package does if there is already a Nim installation.

If choosenim_install will not clash with a preexisting Nim installation, it might be more appropriate for the readme to be updated to have source distributions rely on it instead of making it a global Nimporter library dependency.

Also, Nimporter already automatically installs nimpy if the Nim compiler is installed on the target machine.

I am impressed by these packages as I did not think to use PyPi as a method of installing non-python software before ;)

@juancarlospaco
Copy link
Contributor Author

You have admin on the repo of choosenim_install, change what you want, etc.

If it is installed it will install it again, because what if user broke the installation and want to install it again ?.

@Pebaz
Copy link
Owner

Pebaz commented Feb 14, 2021

Perfect. I think this is good to use then for source distributions. I made a couple changes to allow older Python versions to install choosenim_install. Can you reupload to Pypi when you get a chance?

@Pebaz Pebaz closed this as completed Feb 14, 2021
@juancarlospaco
Copy link
Contributor Author

It does whatever choosenim does on a given condition,
so any improvement should go into choosenim directly instead of workaround specific behaviors.

@Pebaz
Copy link
Owner

Pebaz commented Feb 14, 2021

I'm sorry I don't understand. Could you explain further?

@Pebaz
Copy link
Owner

Pebaz commented Feb 14, 2021

Oh you mean Nim's official choosenim installer, not choosenim_install. Sorry I get it now.

@Pebaz
Copy link
Owner

Pebaz commented Feb 14, 2021

I updated the readme to include choosenim_install.

I don't want to make it a dependency of Nimporter itself because Nim users with custom installations might not like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants