Add GET /folder/{id}/share-links endpoint

Users should be able to see the share links they've created on any given
folder, so this commit adds an endpoint to retrieve all a folder's share
links.

Author: Liam Lloyd-Tucker

Diff for: packages/api/src/folder/controller.test.ts

@@ -2,6 +2,7 @@ import type { NextFunction, Request } from "express";
 import { logger } from "@stela/logger";
 import request from "supertest";
 import { when } from "jest-when";
+import createError from "http-errors";
 import { app } from "../app";
 import { db } from "../database";
 import {
@@ -10,6 +11,7 @@ import {
   verifyUserAuthentication,
 } from "../middleware";
 import type { Folder } from "./models";
+import type { ShareLink } from "../share_link/models";
 
 jest.mock("../database");
 jest.mock("../middleware");
@@ -676,3 +678,118 @@ describe("GET /folder/{id}", () => {
     await agent.get("/api/v2/folder?folderIds[]=2").expect(500);
   });
 });
+
+describe("GET /folder/{id}/share_links", () => {
+  const agent = request(app);
+
+  beforeEach(async () => {
+    (verifyUserAuthentication as jest.Mock).mockImplementation(
+      async (
+        req: Request<
+          unknown,
+          unknown,
+          { userSubjectFromAuthToken?: string; emailFromAuthToken?: string }
+        >,
+        __,
+        next: NextFunction
+      ) => {
+        req.body.emailFromAuthToken = "[email protected]";
+        req.body.userSubjectFromAuthToken =
+          "b5461dc2-1eb0-450e-b710-fef7b2cafe1e";
+
+        next();
+      }
+    );
+    await clearDatabase();
+    await loadFixtures();
+  });
+
+  afterEach(async () => {
+    await clearDatabase();
+    jest.restoreAllMocks();
+    jest.clearAllMocks();
+  });
+
+  test("expect to return share links for a folder", async () => {
+    const response = await agent
+      .get("/api/v2/folder/2/share_links")
+      .expect(200);
+
+    const shareLinks = (response.body as { items: ShareLink[] }).items;
+    expect(shareLinks.length).toEqual(3);
+
+    const shareLink = shareLinks.find((link) => link.id === "1");
+    expect(shareLink?.id).toEqual("1");
+    expect(shareLink?.itemId).toEqual("2");
+    expect(shareLink?.itemType).toEqual("folder");
+    expect(shareLink?.token).toEqual("c0f523e4-48d8-4c39-8cda-5e95161532e4");
+    expect(shareLink?.permissionsLevel).toEqual("viewer");
+    expect(shareLink?.accessRestrictions).toEqual("none");
+    expect(shareLink?.maxUses).toEqual(null);
+    expect(shareLink?.usesExpended).toEqual(null);
+    expect(shareLink?.expirationTimestamp).toEqual(null);
+  });
+
+  test("expect an empty list if folder doesn't exist", async () => {
+    const response = await agent
+      .get("/api/v2/folder/999/share_links")
+      .expect(200);
+
+    const shareLinks = (response.body as { items: ShareLink[] }).items;
+    expect(shareLinks.length).toEqual(0);
+  });
+
+  test("expect empty list if user doesn't have access to the folder's share links", async () => {
+    (verifyUserAuthentication as jest.Mock).mockImplementation(
+      async (
+        req: Request<
+          unknown,
+          unknown,
+          { userSubjectFromAuthToken?: string; emailFromAuthToken?: string }
+        >,
+        __,
+        next: NextFunction
+      ) => {
+        req.body.emailFromAuthToken = "[email protected]";
+        req.body.userSubjectFromAuthToken =
+          "b5461dc2-1eb0-450e-b710-fef7b2cafe1e";
+
+        next();
+      }
+    );
+    const response = await agent
+      .get("/api/v2/folder/2/share_links")
+      .expect(200);
+
+    const shareLinks = (response.body as { items: ShareLink[] }).items;
+    expect(shareLinks.length).toEqual(0);
+  });
+
+  test("expect to log error and return 500 if database lookup fails", async () => {
+    const testError = new Error("test error");
+    jest.spyOn(db, "sql").mockImplementation(async () => {
+      throw testError;
+    });
+
+    await agent.get("/api/v2/folder/1/share_links").expect(500);
+    expect(logger.error).toHaveBeenCalledWith(testError);
+  });
+
+  test("expect 401 if not authenticated", async () => {
+    (verifyUserAuthentication as jest.Mock).mockImplementation(
+      (_, __, next: NextFunction) => {
+        next(createError.Unauthorized("Invalid auth token"));
+      }
+    );
+    await agent.get("/api/v2/folder/1/share_links").expect(401);
+  });
+
+  test("expect 400 if the header values are missing", async () => {
+    (verifyUserAuthentication as jest.Mock).mockImplementation(
+      (_, __, next: NextFunction) => {
+        next();
+      }
+    );
+    await agent.get("/api/v2/folder/1/share_links").expect(400);
+  });
+});

Diff for: packages/api/src/folder/controller.ts

@@ -9,14 +9,17 @@ import {
   extractUserEmailFromAuthToken,
   verifyUserAuthentication,
 } from "../middleware";
-import { patchFolder, getFolders } from "./service";
+import { patchFolder, getFolders, getFolderShareLinks } from "./service";
 import {
   validatePatchFolderRequest,
   validateFolderRequest,
   validateGetFoldersQuery,
 } from "./validators";
 import { isValidationError } from "../validators/validator_util";
-import { validateOptionalAuthenticationValues } from "../validators/shared";
+import {
+  validateOptionalAuthenticationValues,
+  validateBodyFromAuthentication,
+} from "../validators/shared";
 
 export const folderController = Router();
 
@@ -69,3 +72,25 @@ folderController.get(
     }
   }
 );
+
+folderController.get(
+  "/:folderId/share_links",
+  verifyUserAuthentication,
+  async (req: Request, res: Response, next: NextFunction) => {
+    try {
+      validateFolderRequest(req.params);
+      validateBodyFromAuthentication(req.body);
+      const shareLinks = await getFolderShareLinks(
+        req.body.emailFromAuthToken,
+        req.params.folderId
+      );
+      res.status(200).send({ items: shareLinks });
+    } catch (err) {
+      if (isValidationError(err)) {
+        res.status(400).json({ error: err.message });
+        return;
+      }
+      next(err);
+    }
+  }
+);

Diff for: packages/api/src/folder/fixtures/create_test_shareby_urls.sql

@@ -1,46 +1,56 @@
 INSERT INTO
 shareby_url (
+  shareby_urlid,
   folder_linkid,
   urltoken,
   shareurl,
   byaccountid,
   byarchiveid,
   unrestricted,
-  expiresdt
+  expiresdt,
+  defaultaccessrole
 )
 VALUES (
+  1,
   1,
   'c0f523e4-48d8-4c39-8cda-5e95161532e4',
   'https://local.permanent.org/share/c0f523e4-48d8-4c39-8cda-5e95161532e4',
   2,
   1,
   true,
-  null
+  null,
+  'role.access.viewer'
 ),
 (
+  2,
   1,
   '7d6412af-5abe-4acb-808a-64e9ce3b7535',
   'https://local.permanent.org/share/7d6412af-5abe-4acb-808a-64e9ce3b7535',
   2,
   1,
   false,
-  null
+  null,
+  'role.access.viewer'
 ),
 (
+  3,
   1,
   '9cc057f0-d3e8-41df-94d6-9b315b4921af',
   'https://local.permanent.org/share/9cc057f0-d3e8-41df-94d6-9b315b4921af',
   2,
   1,
   true,
-  '2020-01-01'
+  '2020-01-01',
+  'role.access.viewer'
 ),
 (
+  4,
   3,
   '56f7c246-e4ec-41f3-b117-6df4c9377075',
   'https://local.permanent.org/share/56f7c246-e4ec-41f3-b117-6df4c9377075',
   2,
   1,
   true,
-  null
+  null,
+  'role.access.viewer'
 );

Diff for: packages/api/src/folder/queries/get_folder_share_links.sql

@@ -0,0 +1,10 @@
+SELECT shareby_url.shareby_urlid AS "id"
+FROM
+  shareby_url
+INNER JOIN
+  account ON shareby_url.byaccountid = account.accountid
+INNER JOIN
+  folder_link ON shareby_url.folder_linkid = folder_link.folder_linkid
+WHERE
+  folder_link.folderid = :folderId
+  AND account.primaryemail = :email;

Diff for: packages/api/src/folder/service.ts

@@ -20,6 +20,8 @@ import {
 import { requestFieldsToDatabaseFields } from "./helper";
 import { getFolderAccessRole, accessRoleLessThan } from "../access/permission";
 import { AccessRole } from "../access/models";
+import { shareLinkService } from "../share_link/service";
+import type { ShareLink } from "../share_link/models";
 
 const prettifyFolderSortType = (
   sortType: FolderSortOrder
@@ -178,3 +180,28 @@ export const patchFolder = async (
   }
   return result.rows[0].folderId;
 };
+
+export const getFolderShareLinks = async (
+  email: string,
+  folderId: string
+): Promise<ShareLink[]> => {
+  const folderShareLinkIds = await db
+    .sql<{ id: string }>("folder.queries.get_folder_share_links", {
+      email,
+      folderId,
+    })
+    .catch((err) => {
+      logger.error(err);
+      throw new createError.InternalServerError(
+        "Failed to get folder share links"
+      );
+    });
+
+  const shareLinkIds = folderShareLinkIds.rows.map((row) => row.id);
+  const shareLinks = await shareLinkService.getShareLinks(
+    email,
+    [],
+    shareLinkIds
+  );
+  return shareLinks;
+};