Skip to content

Commit c1579f2

Browse files
committed
Make the gcp project id recognizable as a placeholder
1 parent 69ff087 commit c1579f2

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ Overall, only the compute instance accounts for the "majority" of the costs.
142142

143143
The terraform error looks something like this:
144144
```
145-
Error applying IAM policy for cloudrun service "v1/projects/github-spot-runner/locations/us-east1/services/cloudrun-service": Error setting IAM policy for cloudrun service "v1/projects/github-spot-runner/locations/us-east1/services/cloudrun-service": googleapi: Error 400: One or more users named in the policy do not belong to a permitted customer, perhaps due to an Organization policy
145+
Error applying IAM policy for cloudrun service "v1/projects/my-gcp-project-id/locations/us-east1/services/cloudrun-service": Error setting IAM policy for cloudrun service "v1/projects/my-gcp-project-id/locations/us-east1/services/cloudrun-service": googleapi: Error 400: One or more users named in the policy do not belong to a permitted customer, perhaps due to an Organization policy
146146
```
147147

148148
1. Solution: Use project tags: [How to create public Cloud Run services when Domain Restricted Sharing is enforced](https://cloud.google.com/blog/topics/developers-practitioners/how-create-public-cloud-run-services-when-domain-restricted-sharing-enforced?hl=en)

runner-autoscaler/.vscode/launch.json

+5-5
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,11 @@
1212
"program": "main.go",
1313
"output": "debug",
1414
"env": {
15-
"PROJECT_ID": "github-spot-runner",
16-
"ZONE": "europe-west1-c",
17-
"TASK_QUEUE": "projects/github-spot-runner/locations/europe-west1/queues/autoscaler-callback-queue",
18-
"INSTANCE_TEMPLATE": "projects/github-spot-runner/global/instanceTemplates/ephemeral-github-runner",
19-
"SECRET_VERSION": "projects/github-spot-runner/secrets/github-pat-token/versions/latest",
15+
"PROJECT_ID": "my-gcp-project-id",
16+
"ZONE": "us-east1-c",
17+
"TASK_QUEUE": "projects/my-gcp-project-id/locations/us-east1/queues/autoscaler-callback-queue",
18+
"INSTANCE_TEMPLATE": "projects/my-gcp-project-id/global/instanceTemplates/ephemeral-github-runner",
19+
"SECRET_VERSION": "projects/my-gcp-project-id/secrets/github-pat-token/versions/latest",
2020
"GITHUB_ENTERPRISE": "Enterprise;dmVyeXNlY3JldA==",
2121
"GITHUB_ORG": "Organization;dmVyeXNlY3JldA==",
2222
"GITHUB_REPOS": "User/Repo1;dmVyeXNlY3JldA==,User/Repo2;dmVyeXNlY3JldA=="

runner-autoscaler/test/main_test.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,9 @@ var PORT = 9999
1717

1818
var scaler *pkg.Autoscaler
1919

20-
const PROJECT_ID = "github-spot-runner"
21-
const REGION = "europe-west1"
22-
const ZONE = "europe-west1-c"
20+
const PROJECT_ID = "my-gcp-project-id"
21+
const REGION = "us-east1"
22+
const ZONE = "us-east1-c"
2323
const GIT_HUB_ORG = "Privatehive"
2424
const TEST_REPO = "Privatehive/runner-test"
2525
const TEST_REPO_KEY = "repository-" + TEST_REPO

0 commit comments

Comments
 (0)