Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mkdtemp missing brackets #4

Closed
rijobro opened this issue Aug 24, 2020 · 0 comments · Fixed by #5
Closed

mkdtemp missing brackets #4

rijobro opened this issue Aug 24, 2020 · 0 comments · Fixed by #5

Comments

@rijobro
Copy link
Contributor

rijobro commented Aug 24, 2020

In a few places (e.g., 3rd cell here), we have:

root_dir = tempfile.mkdtemp if directory is None else directory

which is missing the brackets:

root_dir = tempfile.mkdtemp() if directory is None else directory

Might be worth grepping and replacing all mkdtemp[space] with mkdtemp()[space].
@rijobro rijobro changed the title mkd mkdtemp missing brackets Aug 24, 2020
@rijobro rijobro mentioned this issue Aug 24, 2020
Merged
@wyli wyli closed this as completed in #5 Aug 24, 2020
@be-redAsmara be-redAsmara mentioned this issue Apr 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

4 Fix mkdtemp rijobro/Tutorials
1 participant
@rijobro