bug: FTPFS incorrectly parses results of LIST command

[adriangb]

I'm connecting to a Linux FTP server that has usernames with a .. The current regex ([\w\-]+) doesn't allow this, and so no directories are listed (side note: would it make sense to error when none of the matchers match and the line isn't empty? It was very confusing at first).

According to the Ubuntu manpage for adduser:

adduser and addgroup enforce conformity to IEEE Std 1003.1-2001, which allows only the following characters to appear in group and user names: letters, digits, underscores, periods, at signs (@) and dashes. The name may no start with a dash. The "$" sign is allowed at the end of usernames (to conform to samba).

Now, some distros may have more stringent restrictions, but I suggest that the regex be expanded to at least accept the pattern mentioned in the manpage for Ubuntu. I think the regex would be [A-Za-z0-9][A-Za-z0-9\-\.\_\@]*[\$]{0,1}.

If you agree, I opened #507 to address this.

[althonos]

Hi Adrian, thanks for the bug report and the quick patch! I also think that the regex should be accepting a large set of characters rather than be conservative. The FTP protocol is really not standardized at all and there are plenty of strand FTP server in the wild, so I'll be happy to merge this patch.

would it make sense to error when none of the matchers match and the line isn't empty? It was very confusing at first.

Absolutely! I think we can probably create a new exception here, inheriting ValueError, and then chain it into an OperationFailed in the relevant part of the FTPFS code so that we can get a detailed error result in case it happens again.

[adriangb]

I opened #508 to track raising an error (this issue will be closed by #507)

[adriangb]

Thank you for the quick turnaround time @althonos! Is there any chance you could cut a patch release with these changes? Thanks!

[althonos]

I'll make a new patch soon, but while we are fixing some issues with FTPFS I think I'll try to get #508 and #497 fixed before.

[adriangb]

Awesome. I'll try to find time to work on #508 this week.