simplify examples structure #1247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1247 +/- ##
======================================
Coverage 92% 92%
======================================
Files 63 63
Lines 3316 3316
======================================
Hits 3040 3040
Misses 276 276 |
Borda
force-pushed
the
simplify-examples
branch
from
5e3c41f to
db1ad56
Compare
|
This pull request is now in conflict... :( |
Borda
force-pushed
the
simplify-examples
branch
from
e616da2 to
2a9ec7e
Compare
|
This pull request is now in conflict... :( |
Borda
force-pushed
the
simplify-examples
branch
2 times, most recently
from
e5b90d4 to
a9a9602
Compare
|
This pull request is now in conflict... :( |
Borda
force-pushed
the
simplify-examples
branch
from
a9a9602 to
7aa1e92
Compare
|
This pull request is now in conflict... :( |
Borda
force-pushed
the
simplify-examples
branch
from
7aa1e92 to
11c583f
Compare
jeffling
reviewed
Mar 31, 2020
Borda
force-pushed
the
simplify-examples
branch
from
11c583f to
100c530
Compare
|
This pull request is now in conflict... :( |
|
@Borda can we close or merge this please? |
|
@williamFalcon merge pls... |
|
@Borda waiting on GPU tests here |
|
the GPU test will not pass because the master is broken... can you run it locally? |
|
@Borda rebase? |
|
@williamFalcon rebased and waiting for tests to pass |
|
This pull request is now in conflict... :( |
|
@Borda mind rebasing again? |
|
@williamFalcon done :] |
alexeykarnachev
pushed a commit
to alexeykarnachev/pytorch-lightning
that referenced
this pull request
Apr 4, 2020
* simplify examples structure * update changelog * fix imports * rename example * rename scripts * changelog
tullie
pushed a commit
to tullie/pytorch-lightning
that referenced
this pull request
Jun 7, 2020
* simplify examples structure * update changelog * fix imports * rename example * rename scripts * changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Simplify the example structure and make it more shallow...
This is a reaction to creating
lightning-boltsso here we keep just the minimal example set to illustrate the Lightning potential :]PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃