Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weekly Patch Release v.1.2.8 [full merge, no squash] #6983

Merged
merged 22 commits into from
Apr 14, 2021
Merged

Weekly Patch Release v.1.2.8 [full merge, no squash] #6983

merged 22 commits into from
Apr 14, 2021

Conversation

SeanNaren
Copy link
Contributor

@SeanNaren SeanNaren commented Apr 13, 2021 •
edited
Loading

What does this PR do?

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

awaelchli and others added 6 commits April 13, 2021 10:19
@awaelchli
Fix EarlyStopping logic when min_epochs not met (#6705)
4ab5579 
Co-authored-by: Carlos Mocholí <[email protected]>

(cherry picked from commit 127c52a)
@awaelchli
CI: fixture for global rank variable reset (#6839)
bc25c23 
(cherry picked from commit b7a22ba)
@ananthsub
[fix] Better support for rank_zero_only setting for SLURM and torchel…
77fbfd9 
…astic (#6802)

Co-authored-by: Adrian Wälchli <[email protected]>
(cherry picked from commit 86e1d9f)
@5n7-sk
Fix csv extension check (#6436)
9799cfd 
Co-authored-by: Carlos Mocholi <[email protected]>
(cherry picked from commit 01b9cf8)
@ananthsub
Remove hardcoding of rank_zero_only.rank in accelerator connector (#6878
593ae70 
)

(cherry picked from commit 968ac09)
@scart97
Fix finetuning complex models correctly unfreezes. (#6880)
9b6374f 
Co-authored-by: Carlos Mocholi <[email protected]>

(cherry picked from commit eb15abc)
@codecov
Copy link

codecov bot commented Apr 13, 2021 •
edited
Loading

Codecov Report

Merging #6983 (6be8dbc) into release/1.2.x (f5f4f03) will decrease coverage by 5%.
The diff coverage is 81%.

❗ Current head 6be8dbc differs from pull request most recent head 51ad15d. Consider uploading reports for the commit 51ad15d to get more accurate results

@@              Coverage Diff               @@
##           release/1.2.x   #6983    +/-   ##
==============================================
- Coverage             92%     88%    -5%     
==============================================
  Files                190     191     +1     
  Lines              13008   13158   +150     
==============================================
- Hits               11982   11524   -458     
- Misses              1026    1634   +608

ethanwharris and others added 4 commits April 13, 2021 11:07
@ethanwharris
Fix DDP_SPAWN compatibility with bug_report_model.py (#6892)
1769e28 
(cherry picked from commit 87f0aea)
@ethanwharris
TPUSpawn + IterableDataset error message (#6875)
6f7cf59 
Co-authored-by: Carlos Mocholí <[email protected]>

(cherry picked from commit 1c2ecbf)
[Fix] Ensure we set the eval/train flag correctly on accelerator model (
78a6ad5 
#6877)

* Ensure we move the model to eval mode before running evaluation

* Ensure we set the flag appropriately across all stages

* Add test, move hooks logic

* Apply same fix to the validate loop

* Update pytorch_lightning/trainer/trainer.py

* Fix function name

* Fix order, add predict

* Shorten the name

* Fix input dm, drop duplicate on predict start hook call, as it's called in the setup function

* Use hook, remove double call

(cherry picked from commit 742c48e)
@kandluis
fix exception raising (#6901)
94eaef6 
(cherry picked from commit 90e37ba)
awaelchli and others added 2 commits April 13, 2021 14:24
Sean Naren and others added 4 commits April 13, 2021 21:29
@awaelchli
Brew update to fix mac tests (#6970)
5d347e9 
* Drop libomp to see what happens

* Drop openmpi/horovod installs

* Revert "Drop libomp to see what happens"

This reverts commit cdd524f

* Update before install

* Skip horovod failing test

(cherry picked from commit e9c3e02)
@awaelchli
[CI] Drop brew update (#6985)
8028386 
(cherry picked from commit 23e8dff)
@liob @awaelchli
Fix Checkpoint issue when using Horovod distributed backend (PyTorchL…
25b4075 
…ightning#6947) (#6958)

Co-Authored-By: Adrian Wälchli <[email protected]>

Co-authored-by: Adrian Wälchli <[email protected]>

(cherry picked from commit b37b58a)
@Borda @awaelchli
update docker base on PT 1.7 (#6931)
c348bfc 
* update docker base on PT 1.7

* fix path

(cherry picked from commit da1ac3a)
@carmocca carmocca mentioned this pull request Apr 13, 2021
Closed
@awaelchli awaelchli mentioned this pull request Apr 13, 2021
Closed
@SeanNaren SeanNaren marked this pull request as ready for review April 14, 2021 18:35
carmocca
carmocca reviewed Apr 14, 2021
View reviewed changes
carmocca
carmocca reviewed Apr 14, 2021
View reviewed changes
carmocca
carmocca reviewed Apr 14, 2021
View reviewed changes
Borda
Borda reviewed Apr 14, 2021
View reviewed changes
@lexierule lexierule merged commit 7e57581 into release/1.2.x Apr 14, 2021
@lexierule lexierule deleted the 1.2.8 branch April 14, 2021 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli awaelchli approved these changes

@Borda Borda Borda approved these changes

@carmocca carmocca carmocca approved these changes

@justusschock justusschock Awaiting requested review from justusschock

@tchaton tchaton Awaiting requested review from tchaton

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.