Skip to content

Commit 9eee0ea

Browse files
alistairjevansalexmg
authored andcommitted
Use await in the Disposer Tests.
1 parent a40320c commit 9eee0ea

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

test/Autofac.Test/Core/DisposerTests.cs

+9-9
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
using System;
22
using System.Collections.Generic;
3-
using System.Linq;
3+
using System.Threading.Tasks;
44
using Autofac.Core;
55
using Autofac.Test.Util;
66
using Xunit;
@@ -59,7 +59,7 @@ public void CannotAddObjectsToDisposerAfterSyncDispose()
5959
}
6060

6161
[Fact]
62-
public void DisposerDisposesOfObjectsAsyncIfIAsyncDisposableDeclared()
62+
public async ValueTask DisposerDisposesOfObjectsAsyncIfIAsyncDisposableDeclared()
6363
{
6464
var instance = new AsyncDisposeTracker();
6565

@@ -74,21 +74,21 @@ public void DisposerDisposesOfObjectsAsyncIfIAsyncDisposableDeclared()
7474
Assert.False(instance.IsAsyncDisposed);
7575

7676
// Now we wait.
77-
result.GetAwaiter().GetResult();
77+
await result;
7878

7979
Assert.False(instance.IsSyncDisposed);
8080
Assert.True(instance.IsAsyncDisposed);
8181
}
8282

8383
[Fact]
84-
public void DisposerDisposesOfObjectsSyncIfIDisposableOnly()
84+
public async ValueTask DisposerDisposesOfObjectsSyncIfIDisposableOnly()
8585
{
8686
var instance = new DisposeTracker();
8787

8888
var disposer = new Disposer();
8989
disposer.AddInstanceForDisposal(instance);
9090
Assert.False(instance.IsDisposed);
91-
disposer.DisposeAsync().GetAwaiter().GetResult();
91+
await disposer.DisposeAsync();
9292
Assert.True(instance.IsDisposed);
9393
}
9494

@@ -107,15 +107,15 @@ public void DisposerDisposesOfObjectsSyncIfIAsyncDisposableDeclaredButSyncDispos
107107
}
108108

109109
[Fact]
110-
public void CannotAddObjectsToDisposerAfterAsyncDispose()
110+
public async ValueTask CannotAddObjectsToDisposerAfterAsyncDispose()
111111
{
112112
var instance = new AsyncDisposeTracker();
113113

114114
var disposer = new Disposer();
115115
disposer.AddInstanceForDisposal(instance);
116116
Assert.False(instance.IsSyncDisposed);
117117
Assert.False(instance.IsAsyncDisposed);
118-
disposer.DisposeAsync().GetAwaiter().GetResult();
118+
await disposer.DisposeAsync();
119119
Assert.False(instance.IsSyncDisposed);
120120
Assert.True(instance.IsAsyncDisposed);
121121

@@ -140,7 +140,7 @@ public void SyncDisposalOnObjectWithNoIDisposableThrows()
140140
}
141141

142142
[Fact]
143-
public void DisposerAsyncDisposesContainedInstances_InReverseOfOrderAdded()
143+
public async ValueTask DisposerAsyncDisposesContainedInstances_InReverseOfOrderAdded()
144144
{
145145
var disposeOrder = new List<object>();
146146

@@ -160,7 +160,7 @@ public void DisposerAsyncDisposesContainedInstances_InReverseOfOrderAdded()
160160
disposer.AddInstanceForDisposal(syncInstance4);
161161
disposer.AddInstanceForAsyncDisposal(asyncOnlyInstance2);
162162

163-
disposer.DisposeAsync().GetAwaiter().GetResult();
163+
await disposer.DisposeAsync();
164164

165165
Assert.Collection(
166166
disposeOrder,

0 commit comments

Comments
 (0)