Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Commit Event #190

Closed
1 task done
kaustav202 opened this issue Jun 1, 2022 · 6 comments · Fixed by #194
Closed
1 task done

Feature request: Commit Event #190

kaustav202 opened this issue Jun 1, 2022 · 6 comments · Fixed by #194
Labels
minor Will be added to next minor release Priority: low Low priority for this issue/pr. Status: In progress This pr or issue is in progress Type: enhancement New feature or request

Comments

@kaustav202
Copy link

Checks

Description

Is there a possibility of adding a commits event as well to the supported events?
That would allow to keep track of all the recent commits as that is the only major activity missing.

Alternatives considered

No response

@kaustav202 kaustav202 added the Type: enhancement New feature or request label Jun 1, 2022
@welcome
Copy link

welcome bot commented Jun 1, 2022

Thanks for opening your first issue here! Your contribution is welcome🙏. Make sure to follow the code of conduct!

@Andre601
Copy link
Member

Andre601 commented Jun 1, 2022

What do you mean with "secret commits"? If you mean commits towards a private repository, then you have to use a Personal Access Token with the repo scope, as events related to private repositories are not something accessible in GitHub's Public Events API using the default GitHub Token (It may not even work at all. Depends on how the Events API behaves with what token).

@kaustav202
Copy link
Author

No I meant public commits only!!

@abhijoshi2k
Copy link
Member

It is possible to add. However, since commits are quite frequent events. It would displace more significant events immediately.
So the commit event has not been added.

What are your views @Andre601 @PuneetGopinath ?

@Andre601
Copy link
Member

Andre601 commented Jun 3, 2022

If it was added, then it should be disabled by default similar to the comments activity.

@abhijoshi2k abhijoshi2k added minor Will be added to next minor release Status: In progress This pr or issue is in progress Priority: low Low priority for this issue/pr. labels Jun 7, 2022
@abhijoshi2k
Copy link
Member

As of current version, we cannot disable events by default. User will have to do it manually.
This was done in one of the previous releases to fix an issue.

@abhijoshi2k abhijoshi2k mentioned this issue Jun 7, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Will be added to next minor release Priority: low Low priority for this issue/pr. Status: In progress This pr or issue is in progress Type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants