Skip to content

Commit 444e1d0

Browse files
committed
[GitHub] TaintNode.js specific PR template (nodejs#57)
* [GitHub] Fork specific PR template * [GitHub] Check for SemVer and Windows test-taint goal
1 parent 34021cf commit 444e1d0

File tree

1 file changed

+6
-10
lines changed

1 file changed

+6
-10
lines changed

.github/PULL_REQUEST_TEMPLATE.md

+6-10
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,12 @@
1-
<!--
2-
Thank you for your pull request. Please provide a description above and review
3-
the requirements below.
1+
<!-- Please provide a description and review the requirements below -->
42

5-
Bug fixes and new features should include tests and possibly benchmarks.
6-
7-
Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md
8-
-->
3+
##### Description
4+
<!-- Description goes here -->
95

106
##### Checklist
117
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->
128

139
- [ ] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes
14-
- [ ] tests and/or benchmarks are included
15-
- [ ] documentation is changed or added
16-
- [ ] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)
10+
- [ ] `make -j4 test-taint` (UNIX) or `vcbuild test-taint` (Windows) passes
11+
- [ ] Documentation is changed or added in [GitHub Wiki](https://github.wdf.sap.corp/security-services/taint-node/wiki)
12+
- [ ] Taint API version updated in ``src/node_version.h`` and ``README.md`` according to semantic versioning rules

0 commit comments

Comments
 (0)