BUG - issue with latest cf-writer module

[longieirl]

Description

A number of issues have been identified when testing the latest version of cf-deploy-config-writier.

Issue 1.
When generateCAPConfig is called to generate the CAP deployment configuration, the package.json is not being updated with the devDependency @sap/cds-dk. This is added as part of the cds add mta command which generates the mta.yaml and also updates the package.json and is required when the before-all script is executed;

build-parameters:
  before-all:
    - builder: custom
      commands:
        - npm ci
        - npx cds build --production

Issue 2.
If there is more than one HTML5 app in the CAP apps folder, when generateCAPConfig is executed, it appends the HTML5 apps to the mta.yaml using the following structure;

  - name: captestprojectproject2
    type: html5
    path: app/project2
    build-parameters:
      build-result: dist
      builder: custom
      commands:
        - npm ci
        - npm run build
      supported-platforms:
        []

This module type uses a different naming convention i.e. captestprojectproject2 instead of project2 and the command npm run build is not supported for SAP Fiori generated apps. To support SAP Fiori generated apps in the mta.yaml, the command needs to be changed to npm run build:cf.

Steps to Reproduce

Expected results

1. mta.yaml is updated with correct build steps for HTML5 apps generated using sap fiori tools

Actual results

1. mta.yaml is not updated with correct build steps

Screenshots

If applicable, add screenshots to help explain the problem.

Version/Components/Environment

Add any other context about the problem here
OS:

• Mac OS
• Windows
• Other

Root Cause Analysis

Problem

{describe the problem}

Fix

{describe the fix}

Why was it missed

{Some explanation why this issue might have been missed during normal development/testing cycle}

How can we avoid this

{if we don’t want to see this type of issues anymore what we should do to prevent}