Skip to content

p13n.engine with m.Table, variant name can not be changed in mobile #4258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2 tasks done
memeteminozturk opened this issue Apr 11, 2025 · 2 comments
Open
2 tasks done

Comments

@memeteminozturk
Copy link

memeteminozturk commented Apr 11, 2025

What is the issue and how can we reproduce it?

  1. Open the sample
    https://sapui5.hana.ondemand.com/#/entity/sap.m.Table/sample/sap.m.sample.p13n.Engine
    or
    https://openui5nightly.hana.ondemand.com/1.134.0/#/entity/sap.m.p13n.Engine/sample/sap.m.sample.p13n.Engine
  2. Using your browser's developer tools, select and activate any mobile device emulation.
  3. Click on variants
  4. Choose the "Save As" option, enter a name, and save the new variant.
  5. Click "Manage" and modify its name
  6. Refresh page

Observed Behavior:

After refreshing the page, the updated name of the variant is not retained.

Expected Behavior:

The modified name should persist after the page refresh.

Which OpenUI5 version is your project targeting?

1.134.0, 1.134.1

Is the issue device- or browser-specific?

No response

Confirmation

  • I have searched the existing issues and reviewed the relevant documentation as well as the API reference.
  • I am not disclosing any internal or sensitive information.
@plamenivanov91
Copy link
Contributor

Hello @memeteminozturk ,

I didn't see any "variants" button but I clicked on the gear icon where I added a new column to the table and after refresh the column (setting) was gone.

Is this what you mean ?

Also, I believe this is expected behaviour as Demo Kit is not keeping any sample settings on refresh.

Regards,
Plamen Ivanov

@memeteminozturk
Copy link
Author

memeteminozturk commented Apr 21, 2025

Hi @plamenivanov91,

Apologies for the earlier confusion. I've outlined the steps more clearly below for your reference:

  1. Open the sample https://sapui5.hana.ondemand.com/1.135.0/#/entity/sap.m.p13n.Engine/sample/sap.m.sample.p13n.Engine

  2. Enable mobile device emulation using your browser’s developer tools (e.g., select iPhone 12 Pro), then refresh the page.

  3. Click on the "Standard" variant. (Note: The label might differ depending on your browser's language settings.)

Image

  1. Click 'Save As'.

Image

  1. In the opening dialog, enter a new variant name and click 'Save'.

Image

  1. Select the newly saved variant, then click the "Manage" button.

Image

  1. Change the variant's name in the management dialog and save.

Image

  1. Refresh the page.

The variant name displayed should revert to the initial name you set, not the one you updated in the "Manage" step.

Image
Before refresh

Image
After refresh

If there are still any misunderstandings or if something remains unclear, I’d be happy to assist further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants