Skip to content

sap.ui.table.Table with fixed columns dont respect IDragInfo.getEnable() #4263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2 tasks done
danielang opened this issue Apr 16, 2025 · 1 comment
Open
2 tasks done

Comments

@danielang
Copy link

What is the issue and how can we reproduce it?

  1. Open the sample https://jsbin.com/yajubuyebe/1/edit?html,js,output
  2. Drag the fixed column (1st one) and also one of the non-fixed columns
  3. Flip the Switch
  4. Drag the fixed column (1st one) and also one of the non-fixed columns
  5. Notice that if the DragInfo is disabled you can still drag the fixed columns

Expected behavior:

In case all IDragInfo in the dragDropConfig aggregation of a table are disabled, I expect that the fixed columns are not draggable.

Solution:

This could be fixed by modifying line 929 of the TableRenderer to:

var bRowsDraggable = oTable.getDragDropConfig().some(function(oDragDropInfo) {
    return oDragDropInfo.getMetadata().isInstanceOf("sap.ui.core.dnd.IDragInfo") && oDragDropInfo.getSourceAggregation() === "rows" && oDragDropInfo.getEnabled();
});

Which OpenUI5 version is your project targeting?

1.120

Is the issue device- or browser-specific?

No

Confirmation

  • I have searched the existing issues and reviewed the relevant documentation as well as the API reference.
  • I am not disclosing any internal or sensitive information.
@tsanislavgatev
Copy link
Contributor

Hello @danielang ,

Thank you for sharing this finding. I've created an internal incident DINC0486967. The status of the issue will be updated here in GitHub.
Regards,
Tsanislav

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants