Skip to content

[SF | a11y | ui5-tree]: JAWS is not reading the icon name along with the group title #7481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task done
dp1704 opened this issue Aug 24, 2023 · 4 comments · Fixed by #11106
Closed
1 task done

[SF | a11y | ui5-tree]: JAWS is not reading the icon name along with the group title #7481

dp1704 opened this issue Aug 24, 2023 · 4 comments · Fixed by #11106
Assignees
@dobrinyonkov
Labels
ACC High Prio SAP SF TOPIC P
Milestone
2.10.0

Comments

@dp1704
Copy link

dp1704 commented Aug 24, 2023

Bug Description

Please find below link:

https://sap.github.io/ui5-webcomponents/playground/?path=/story/main-tree--basic

screen reader is not reading the icon name here like paste for example from the above link with group title. only reading the group title.

Affected Component

ui5-Tree

Expected Behaviour

it should read the icon name along with group title.

Isolated Example

No response

Steps to Reproduce

  1. go to this link: https://sap.github.io/ui5-webcomponents/playground/?path=/story/main-tree--basic
  2. turn on the screen reader like JAWS
  3. notice it only announce the group title not the icon

Log Output, Stack Trace or Screenshots

No response

Priority

High

UI5 Web Components Version

1.16.0

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@dp1704 dp1704 added the bug This issue is a bug in the code label Aug 24, 2023
@ndeshev ndeshev self-assigned this Aug 29, 2023
@ndeshev
Copy link
Contributor

ndeshev commented Aug 29, 2023 •
edited
Loading

Hello @dp1704,

The icon has explicit role="presentation" and aria-hidden="true" attributes to avoid the screen reader announcements by design. It is implemented according to the screen reader support specifications in both UI5 WebComponents and UI5 classic.

We will double-check the request again with our accessibility experts, if it should be re-specified and if that is the case I will re-open the issue.

Kind regards,
Nikolay

@ndeshev ndeshev closed this as completed Aug 29, 2023
@ndeshev ndeshev added wontfix This will not be worked on and removed bug This issue is a bug in the code labels Aug 29, 2023
@dobrinyonkov dobrinyonkov reopened this Sep 4, 2023
@dobrinyonkov dobrinyonkov assigned dobrinyonkov and unassigned ndeshev Sep 4, 2023
@dobrinyonkov dobrinyonkov added TOPIC P High Prio and removed wontfix This will not be worked on labels Sep 4, 2023
@dobrinyonkov dobrinyonkov mentioned this issue Sep 12, 2023
Closed
@dobrinyonkov
Copy link
Contributor

Internal Refernce: BGSOFUIPIRIN-6223

@dobrinyonkov
Copy link
Contributor

dobrinyonkov commented Sep 13, 2023 •
edited
Loading

Hi @dp1704,

in order to enable various customizations of the icon, we will provide a slot named customIcon. This way it would be possible to change the tooltip, the accessible name or any other state of the icon. Styles will still be applied by default on framework level.

Kind Regards,
Dobrin

@petyabegovska petyabegovska moved this to Approved in Planning - Topic P Jun 21, 2024
@yanaminkova yanaminkova mentioned this issue Mar 12, 2025
Closed
@dobrinyonkov dobrinyonkov moved this from Approved to In Progress in Planning - Topic P Mar 14, 2025
@dobrinyonkov dobrinyonkov added this to the 2.9.0 milestone Mar 14, 2025
@yanaminkova yanaminkova mentioned this issue Mar 14, 2025
Merged
@dobrinyonkov dobrinyonkov modified the milestones: 2.9.0, 2.10.0 Apr 4, 2025
yanaminkova added a commit that referenced this issue Apr 10, 2025
@yanaminkova
feat(ui5-tree-item): image slot added (#11106)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
4d972c8 
This feature enables semantic icons to be used with the ui5-tree-item

Fixes: #7481
@github-project-automation github-project-automation bot moved this from In Progress to Completed in Planning - Topic P Apr 10, 2025
@github-actions GitHub Actions
Copy link

This issue has been closed. To reopen, just leave a comment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dobrinyonkov dobrinyonkov

Labels
ACC High Prio SAP SF TOPIC P
Projects
Planning - Topic P
Status: Completed
Milestone
2.10.0
4 participants
@ndeshev @petyabegovska @dobrinyonkov @dp1704