Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data Races #318

Closed
Cyclic opened this issue Jun 10, 2024 · 0 comments · Fixed by #341
Closed

Data Races #318

Cyclic opened this issue Jun 10, 2024 · 0 comments · Fixed by #341

Comments

@Cyclic
Copy link

Cyclic commented Jun 10, 2024

It seems like the ObservedObject should be upgraded to the new @observable macro, and the closures updated to structured concurrency with actor isolation in many instances. Testing with Xcode 16 beta.

Data race in closure #1 (Swift.Int, Swift.Int, Swift.Optional<Foundation.URL>) -> () in SDWebImageSwiftUI.ImageManager.load(url: Swift.Optional<Foundation.URL>, options: __C.SDWebImageOptions, context: Swift.Optional<Swift.Dictionary<__C.SDWebImageContextOption, Any>>) -> () at 0x33a961260

image
image

image

image

image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the data race because progress block is called in non-main queue SDWebImage/SDWebImageSwiftUI
1 participant
@Cyclic