fix: window direction and autocomplete closing on position update

closes #240

Author: Saghen

lua/blink/cmp/windows/autocomplete.lua

@@ -141,9 +141,14 @@ function autocomplete.open_with_items(context, items)
   vim.iter(autocomplete.event_targets.on_open):each(function(callback) callback() end)
 
   if not autocomplete.auto_show then return end
-  autocomplete.win:open()
 
+  autocomplete.win:open()
   autocomplete.update_position(context)
+
+  -- it's possible for the window to close after updating the position
+  -- if there was nowhere to place the window
+  if not autocomplete.win:is_open() then return end
+
   autocomplete.set_has_selected(autocmp_config.selection == 'preselect')
 
   -- todo: some logic to maintain the selection if the user moved the cursor?
@@ -154,9 +159,11 @@ end
 
 function autocomplete.open()
   if autocomplete.win:is_open() then return end
-  vim.iter(autocomplete.event_targets.on_open):each(function(callback) callback() end)
+
   autocomplete.win:open()
   autocomplete.set_has_selected(autocmp_config.selection == 'preselect')
+
+  vim.iter(autocomplete.event_targets.on_open):each(function(callback) callback() end)
 end
 
 function autocomplete.close()

lua/blink/cmp/windows/lib/init.lua

@@ -227,7 +227,7 @@ function win:get_vertical_direction_and_height(direction_priority)
   local direction_priority_by_space = vim.fn.sort(vim.deepcopy(direction_priority), function(a, b)
     local distance_a = math.min(max_height, get_distance(a))
     local distance_b = math.min(max_height, get_distance(b))
-    return distance_a < distance_b and -1 or distance_a > distance_b and 1 or 0
+    return (distance_a < distance_b) and 1 or (distance_a > distance_b) and -1 or 0
   end)
 
   local direction = direction_priority_by_space[1]
@@ -282,7 +282,7 @@ function win:get_direction_with_window_constraints(anchor_win, direction_priorit
     local constraints_b = direction_constraints[b]
     local distance_a = math.min(max_height, constraints_a.vertical, constraints_a.horizontal)
     local distance_b = math.min(max_height, constraints_b.vertical, constraints_b.horizontal)
-    return distance_a < distance_b and -1 or distance_a > distance_b and 1 or 0
+    return distance_a < distance_b and 1 or distance_a > distance_b and -1 or 0
   end)
 
   local border_size = self:get_border_size()