Skip to content

Lua LSP's @param;@return suggestions not picked up #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chrisgrieser opened this issue Oct 18, 2024 · 3 comments
Closed

Lua LSP's @param;@return suggestions not picked up #135

chrisgrieser opened this issue Oct 18, 2024 · 3 comments

Comments

@chrisgrieser
Copy link
Contributor

The lua LSP has a very useful luadocs annotation, typing --- in the line before a function will result in a @param;@return suggestions that autofills a lot of function annotations for you.

However, this suggestion does not seem to work for blink.cmp. It's just one suggestion, but a frequently used and important one, since it is the only method to somewhat auto-generate function annotations.

I tried fiddling with opts.triggers.completion.keyword_regex, and - does work correctly as trigger character (and is already configured as one in the default config), so the fact that the suggestion is triggered via --- should not be the issue here. Thus, I assume the issue lies with blink.cmp somehow not picking this suggestions from the lua LSP.

@Saghen Saghen closed this as completed in 569156f Oct 18, 2024
@Saghen
Copy link
Owner

Saghen commented Oct 18, 2024

We were filtering on the --- which led to no matches. I've excluded - if it comes at the beginning of the keyword, which I don't believe should break other use cases

@chrisgrieser
Copy link
Contributor Author

Sorry to bother you, but this has not been fixed yet. I just switched to 0.4.0, and there still is no @param;@return suggestion when typing ---.

@Saghen
Copy link
Owner

Saghen commented Oct 24, 2024

Sorry about that, got broken again while reworking that code. Should be fixed in v0.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants