Skip to content

fix(keymaps): expr can't nvim_buf_set_text #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 27, 2024
Merged

Conversation

joaomendoncaa
Copy link
Contributor

Bumped into conflicts when trying to use completions from supermaven (with the TAB keymap). Changing blink's keymaps to not be triggered as expressions saved the day — let me know if this is not the intended fix.

error:
image

@Saghen
Copy link
Owner

Saghen commented Oct 26, 2024

I think the fix would be to wrap the callback in vim.schedule/vim.schedule_wrap although I'm surprised that would be needed in the first place

fix(keymaps): conflicting with other runtime keymaps
@joaomendoncaa
Copy link
Contributor Author

I think the fix would be to wrap the callback in vim.schedule/vim.schedule_wrap although I'm surprised that would be needed in the first place

Even better! I also don't fully understand why there's a conflict in the first place, but i'd say having it scheduled is just good practice regardless. Thank you for your time.

@Saghen Saghen merged commit 1a55fd1 into Saghen:main Oct 27, 2024
@Saghen
Copy link
Owner

Saghen commented Oct 27, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants