fix: use correct prev/next keymap for k and j #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
Should the default be C-n and C-p? |
kuator
added a commit
to kuator/blink.cmp
that referenced
this pull request
Oct 9, 2024
Saghen#23 (comment) nvim-cmp uses `ctrl-n` and `ctrl-p` by default for choosing items in a completion windows. So does vanilla Neovim and Emacs and pretty much every terminal application I know of. `ctrl-j` and `ctrl-k` are unidiomatic.
Saghen
pushed a commit
that referenced
this pull request
Oct 9, 2024
* fix: use correct prev/next keymap #23 (comment) nvim-cmp uses `ctrl-n` and `ctrl-p` by default for choosing items in a completion windows. So does vanilla Neovim and Emacs and pretty much every terminal application I know of. `ctrl-j` and `ctrl-k` are unidiomatic. * Update README.md
lopi-py
pushed a commit
to lopi-py/blink.cmp
that referenced
this pull request
Oct 10, 2024
lopi-py
pushed a commit
to lopi-py/blink.cmp
that referenced
this pull request
Oct 10, 2024
* fix: use correct prev/next keymap Saghen#23 (comment) nvim-cmp uses `ctrl-n` and `ctrl-p` by default for choosing items in a completion windows. So does vanilla Neovim and Emacs and pretty much every terminal application I know of. `ctrl-j` and `ctrl-k` are unidiomatic. * Update README.md
lopi-py
pushed a commit
to lopi-py/blink.cmp
that referenced
this pull request
Oct 10, 2024
lopi-py
pushed a commit
to lopi-py/blink.cmp
that referenced
this pull request
Oct 10, 2024
* fix: use correct prev/next keymap Saghen#23 (comment) nvim-cmp uses `ctrl-n` and `ctrl-p` by default for choosing items in a completion windows. So does vanilla Neovim and Emacs and pretty much every terminal application I know of. `ctrl-j` and `ctrl-k` are unidiomatic. * Update README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the incorrect default keymap for
select_nextandselect_prev.