Skip to content

fix: allow to be lazy loaded on InsertEnter #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2024

Conversation

lopi-py
Copy link
Contributor

@lopi-py lopi-py commented Nov 2, 2024

fixes #229

@Saghen
Copy link
Owner

Saghen commented Nov 2, 2024

Thanks, please add a small comment explaining why we need to make that check. Actually it's clear enough as is

@Saghen Saghen merged commit 9d50661 into Saghen:main Nov 2, 2024
@lopi-py
Copy link
Contributor Author

lopi-py commented Nov 2, 2024

Actually it's clear enough as is

Oops, I just added the comment, the actual reason we miss the InsertEnter event is because we check if the binary is installed first. lmk if you want me to push the comment or if it's fine as is

@Saghen
Copy link
Owner

Saghen commented Nov 2, 2024

Yeah feel free to push it on main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autocomplete intermittently stops working - .zshrc
2 participants