Skip to content

Purpose of show_on_insert_on_trigger_character #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sQVe opened this issue Oct 8, 2024 · 1 comment
Closed

Purpose of show_on_insert_on_trigger_character #25

sQVe opened this issue Oct 8, 2024 · 1 comment

Comments

@sQVe
Copy link
Contributor

sQVe commented Oct 8, 2024

Hey, 👋🏼

First and foremost, great job with this plugin and its performance; it's a breath of fresh air!

I would appreciate some further insights on what the show_on_insert_on_trigger_character option is meant to do.

The behavior of the completion menu is different when trying to expand a {} via append or insert. The attached screen recording shows the issue nicely, where I expand the block with insert first, without getting a completion, and then with append.

This behavior feels off, and it is only there if I enable show_on_insert_on_trigger_character. If I disable it, the behavior of append/insert is consistent.

simplescreenrecorder-2024-10-08_11.04.21.mp4
@Saghen Saghen closed this as completed in ebbce90 Oct 11, 2024
@Saghen
Copy link
Owner

Saghen commented Oct 11, 2024

luals seems special in that it uses the trigger character to determine whether to show items. There was a tricky edge case where append was causing a double request to the LSP, one with and one without the trigger character. The latter request would end up showing LSP items.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants