Add blink_luasnip

[leiserfg]

No description provided.

[Saghen]

Sorry for the wait, I'll give it a test on my system soon

[Saghen]

This line should be kept

[leiserfg]

@Saghen it works fine in 0.6.2 but was somehow failing in master, let me know if I can help to debug.

[Saghen]

The accept logic was changed to first apply the item and then call source's execute function. where as before, it would hand off everything to the source @leiserfg. You might want to set insertText = "" and then expand the snippet. You could grab the text that was removed via context.line:sub(context.bounds.start_col, context.bounds.start_col + context.bounds.length - 1) (i.e. for TM_CURRENT_LINE)

[leiserfg]

Thanks @Saghen that was what I understood but was waiting for a stable release with the changes.

[leiserfg]

LuaSnip does more stuff with the current line and wants access to the range to clear it by itself. I was thinking to set insertText to the triggering word, so that LuaSnip will "see" the same. But that looks a bit dirty to me. I think it would be cleaner to have a way for asking blink.cmp not to edit the text.

Edit: My hack won't work event work as the items changing the text won't update the insertText.

Edit: Forget about it, it is indeed possible to feed luasnip with the line as you advised, thanks.

[Saghen]

It's messy but perhaps you could add back the text before calling luasnip? Using this snippet to get the text (not tested fyi, but should work):

context.line:sub(context.bounds.start_col, context.bounds.start_col + context.bounds.length - 1)

I'll revisit the execute function in the future so you don't have to hack around this

[leiserfg]

I managed to make it work following your previous suggestion, right now the only issue I see is that the snippet is expanded but it goes to "normal" mode instead of staying in "select" mode as it should.

[soifou]

the only issue I see is that the snippet is expanded but it goes to "normal" mode instead of staying in "select" mode as it should.

I think you're missing the required insertTextFormat = vim.lsp.protocol.InsertTextFormat.Snippet, see here

[leiserfg]

If I pass insertTextFormat = vim.lsp.protocol.InsertTextFormat.Snippet then it crashes with

10.2/share/nvim/runtime/lua/vim/lsp/_snippet_grammar.lua:177: snippet parsing failed

[Saghen]

That's only if you want blink.cmp to expand the insertText as a snippet which you don't want

[leiserfg]

Yes but it's passing the inserText any way, I tried passing

inserText = " ",  -- an space
insertTextFormat = vim.lsp.protocol.InsertTextFormat.Snippet 

and that worked fine (kept the snippet in select mode), so I think I will use that as a workaround, but IMHO passing

inserText = "",  -- empty
insertTextFormat = vim.lsp.protocol.InsertTextFormat.Snippet 

should not break.

[Saghen]

You should be using vim.lsp.protocol.InsertTextFormat.PlainText with insertText = "". The source should switch the mode to select as part of the execute

[leiserfg]

In all the cases I'm using kind = vim.lsp.protocol.CompletionItemKind.Snippet, in case it matters

This keeps changing the mode to Normal

insertTextFormat = vim.lsp.protocol.InsertTextFormat.PlainText,
insertText = ""

This crashes because tries to parse the snippet

insertTextFormat = vim.lsp.protocol.InsertTextFormat.Snippet,
insertText = ""

This one works well but inserts the space:

insertTextFormat = vim.lsp.protocol.InsertTextFormat.Snippet,
insertText = " "

This one works well but to me is a HACK 😄 :

insertTextFormat = vim.lsp.protocol.InsertTextFormat.Snippet,
insertText = "$0"