-
Notifications
You must be signed in to change notification settings - Fork 233
fix!: autocompletion window components alignment #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! The multiple fills and max_width especially make layouts much easier. One small change, a rebase and I'll merge
cc34183
to
35fd1b9
Compare
I had fun with git 🥹. |
Yep I would, should they be at the beginning instead? |
It feels like its missaligned with the other items, actually, the snippet indicator is taken from nvim-cmp |
Thank you! |
Before


After
I have a custom
windows.autocomplete.draw
function:Notes
windows.autocomplete.min_width
andwindows.autocomplete.max_width
since it's way easier to maintain the alignment without those, but in compensation,max_width
component option was added:Also it feels weird to have unnecessary blank spacing with the
windows.autocomplete.min_width
optionfill
components