Let's try something else, to finish it up

Author: SvenjaReißaus

classes/artifacts/Factions_jar/Factions.jar

@@ -176,7 +176,7 @@ public interface Faction extends EconomyParticipator {
 	boolean noMonstersInTerritory();
 
 	boolean isNormal();
-
+	boolean isSystemFaction();
 	@Deprecated
 	boolean isNone();
 

src/main/java/com/massivecraft/factions/Faction.java

@@ -501,7 +501,9 @@ else if (landOwned && !myFaction.getOwnerListString(loc).contains(player.getName
 			}
 			me.msg(TL.GENERIC_NOPERMISSION, action);
 			return false;
-		} else return access == Access.ALLOW;
+		} else if (access == Access.ALLOW) return true;
+		me.msg(TL.GENERIC_NOPERMISSION, action);
+		return false;
 	}
 
 	private static boolean CheckActionState(Faction target, FLocation location, FPlayer me, PermissableAction action, boolean pain) {

src/main/java/com/massivecraft/factions/listeners/FactionsBlockListener.java

@@ -169,16 +169,15 @@ public static boolean canPlayerUseBlock(Player player, Block block, boolean just
 		Relation rel = myFaction.getRelationTo(otherFaction);
 
 		// no door/chest/whatever protection in wilderness, war zones, or safe zones
-		if (!otherFaction.isNormal()) return true;
+		if (otherFaction.isSystemFaction()) return true;
+		if (myFaction.isWilderness()) {
+			me.msg(TL.GENERIC_NOPERMISSION, TL.GENERIC_DOTHAT);
+			return false;
+		}
 
 		if (SavageFactions.plugin.getConfig().getBoolean("hcf.raidable", false) && otherFaction.getLandRounded() > otherFaction.getPowerRounded())
 			return true;
 
-		if (!rel.isMember() || !otherFaction.playerHasOwnershipRights(me, loc) && player.getItemInHand().getType() != null) {
-			if (player.getItemInHand().getType().toString().toUpperCase().contains("DOOR"))
-				return false;
-		}
-
 		PermissableAction action = null;
 		if (SavageFactions.plugin.mc113) {
 			switch (block.getType()) {
@@ -320,8 +319,6 @@ public static boolean canPlayerUseBlock(Player player, Block block, boolean just
 
 		// Move up access check to check for exceptions
 		if (!otherFaction.getId().equals(myFaction.getId())) { // If the faction target is not my own
-			if (SavageFactions.plugin.getConfig().getBoolean("hcf.raidable", false) && otherFaction.getLandRounded() > otherFaction.getPowerRounded())
-				return true;
 			// Get faction pain build access relation to me
 			boolean pain = !justCheck && otherFaction.getAccess(me, PermissableAction.PAIN_BUILD) == Access.ALLOW;
 			return CheckPlayerAccess(player, me, loc, otherFaction, otherFaction.getAccess(me, action), action, pain);
@@ -872,22 +869,20 @@ public void onPlayerInteract(PlayerInteractEvent event) {
 
 		Block block = event.getClickedBlock();
 		Player player = event.getPlayer();
-		FLocation loc = new FLocation(block.getLocation());
-		Faction faction = MemoryBoard.getInstance().getFactionAt(loc);
-		FPlayer fplayer = MemoryFPlayers.getInstance().getByPlayer(player);
 
         // Check if the material is bypassing protection
         if (Conf.territoryBypasssProtectedMaterials.contains(block.getType())) return;
 
 		if (block == null) return;  // clicked in air, apparently
 
 		if (!block.getType().isInteractable()) return;
-
+		player.sendMessage("Checking if you can use that block");
 		if (!canPlayerUseBlock(player, block, false)) {
 			event.setCancelled(true);
 			event.setUseInteractedBlock(Event.Result.DENY);
 			return;
 		}
+		player.sendMessage("Checking if you can use that item");
 		if (!playerCanUseItemHere(player, block.getLocation(), event.getMaterial(), false)) {
 			event.setCancelled(true);
 			event.setUseInteractedBlock(Event.Result.DENY);
@@ -1042,6 +1037,7 @@ else if (landOwned && !myFaction.getOwnerListString(loc).contains(player.getName
 				return false;
 			}
 		}
+		me.msg(TL.GENERIC_NOPERMISSION, action);
 		return false;
 	}
 }

src/main/java/com/massivecraft/factions/listeners/FactionsPlayerListener.java

@@ -754,6 +754,7 @@ public boolean isSafeZone() {
 	public boolean isWarZone() {
 		return this.getId().equals("-2");
 	}
+	public boolean isSystemFaction() { return this.isSafeZone() || this.isWarZone() || this.isWilderness(); }
 
 	public boolean isPlayerFreeType() {
 		return this.isSafeZone() || this.isWarZone();