Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ODEProblem over JumpProblem when there are no ODEs #3496

Merged
merged 2 commits into from
Mar 26, 2025

Conversation

isaacsas
Copy link
Member

@isaacsas isaacsas commented Mar 25, 2025

I don't understand why tests didn't catch this, but it is causing us issues in Catalyst with initialization-related errors for variable rate jump problems (that have no coupled ODEs). Given build_initializeprob = false is set in the coupled ODE-jump case, it seems like it was just an oversight to not include it here too.

@isaacsas isaacsas changed the title Fix ODEProblem over JumpProblem Fix ODEProblem over JumpProblem when there are no ODEs Mar 25, 2025
@isaacsas
Copy link
Member Author

Test failures seem unrelated.

@isaacsas
Copy link
Member Author

@ChrisRackauckas any chance we could get this merged and get a release with it? This is the last thing preventing us from finishing the PR that gets Catalyst master working with MTK again.

@ChrisRackauckas ChrisRackauckas merged commit 1dd173c into SciML:master Mar 26, 2025
39 of 45 checks passed
@ChrisRackauckas
Copy link
Member

I guess this is fine as a stopgap solution. We shouldn't necessary rely on this down the line because it's an interface break. @AayushSabharwal can you prioritize getting initialize prob infrastructure onto JumpProblems working? it should just forward down to the prob in there. We can do a release with this to get tests passing and such and get the rest of downstream going for now, but we should leave open the very real probability that it will revert in hopefully a week, but with the fix to JumpProblems matching the AbstractSciMLProblem interface requirements on inits.

@AayushSabharwal
Copy link
Member

SciML/JumpProcesses.jl#470 is the discussion on why initialization in JumpProcesses is incredibly problematic.

@isaacsas isaacsas deleted the fix_ode_jumps branch March 26, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants