Skip to content

dnscommon.r2py cannot parse replies containing NS, PTR types of queries #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pranavnyu opened this issue May 5, 2015 · 1 comment
Assignees

Comments

@pranavnyu
Copy link

  • dnscommon.r2py replies with KeyError when query is of type NS
    for e.g. present code returns this:
User traceback:
  "dylink.r2py", line 546, in <module>
  "dylink.r2py", line 407, in dylink_dispatch
  "dylink.r2py", line 520, in evaluate
  "librepy.r2py", line 153, in <module>
  "dylink.r2py", line 446, in _dylink_dispatch
  "dylink.r2py", line 407, in dylink_dispatch
  "dylink.r2py", line 520, in evaluate
  "ut_dnsquery_namingserver.r2py", line 11, in <module>
  "ut_dnsquery_namingserver.r2py", line 8, in test_namingServer
  "dnsquery.r2py", line 222, in namingServer
  "dnsquery.r2py", line 140, in dns_connection
  "dnscommon.r2py", line 406, in convert_packet_to_dictionary
  "dnscommon.r2py", line 459, in _read_answer_section
  "dnscommon.r2py", line 504, in _read_single_answer

Exception (with type 'exceptions.KeyError'): 49164
Testing module: dnsquery
    Running: ut_dnsquery_reverselookup.r2py                     [ FAIL ]
--------------------------------------------------------------------------------
Standard out :
..............................Produced..............................
('173.252.120.6', {'address': '21.101.100.103'})

rather output should be domain name for the respective IP address

We need to create a patch for the same in https://github.com/SeattleTestbed/seattlelib_v2/blob/master/dnscommon.r2py#L464 in _read_single_answer function.
-> https://github.com/SeattleTestbed/seattlelib_v2/blob/master/dnscommon.r2py#L522 should be edited and code should be added for different types like already done for type 'SOA'.

@asm582
Copy link

asm582 commented May 7, 2015

I tried to test some of your implementations may be i am incorrect but i found that your namingServer implementation does not seem to be working for me. I think i added changes for the dnscommon.r2py that you suggested but it hangs when i use you dnsquery.r2py library to test it.

@pranavnyu pranavnyu changed the title dnscommon.r2py doesn't replies with error in NS, PTR type of queries dnscommon.r2py doesn't reply for NS, PTR type of queries May 7, 2015
@pranavnyu pranavnyu changed the title dnscommon.r2py doesn't reply for NS, PTR type of queries dnscommon.r2py doesn't reply for NS, PTR types of queries May 7, 2015
@pranavnyu pranavnyu changed the title dnscommon.r2py doesn't reply for NS, PTR types of queries dnscommon.r2py cannot parse replies containing NS, PTR types of queries May 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants