Fix all typescript errors

Author: nloomans

Diff for: gulpfile.js

@@ -67,9 +67,15 @@ function buildRenderer() {
     delete webpackConfig.devtool;
   }
   // Build source
-  gulp.src(webpackConfig.entry)
-    .pipe(webpack(webpackConfig))
-    .pipe(gulpif(config.isRelease, uglify()))
+  return gulp.src(webpackConfig.entry)
+    .pipe(webpack({
+      ...webpackConfig,
+      mode: process.env.NODE_ENV || 'development',
+    })
+    // Listening for errors ensures that gulp doesn't exist when an error
+    // happens. webpack already logs the errors to the console so we'll just
+    // use a no-op function here.
+    .on('error', () => {}))
     .pipe(gulp.dest(config.paths.renderer.dest));
 }
 

Diff for: package.json

@@ -19,10 +19,11 @@
     "fast-xml-parser": "3.12.0"
   },
   "devDependencies": {
-    "@types/react": "16.4.10",
-    "@types/react-dom": "16.0.7",
-    "@types/react-router-dom": "4.3.0",
-    "@types/react-virtualized": "9.18.6",
+    "@types/node": "^10.9.2",
+    "@types/react": "^16.4.11",
+    "@types/react-dom": "^16.0.7",
+    "@types/react-router-dom": "^4.3.0",
+    "@types/react-virtualized": "^9.18.7",
     "awesome-typescript-loader": "5.2.0",
     "copy-webpack-plugin": "4.5.2",
     "cross-env": "^5.2.0",
@@ -41,7 +42,7 @@
     "tslint": "5.11.0",
     "typescript": "3.0.1",
     "webpack": "4.16.4",
-    "webpack-cli": "3.1.0",
+    "webpack-cli": "^3.1.0",
     "webpack-dev-server": "3.1.4",
     "webpack-stream": "5.1.0"
   }

Diff for: src/main/Main.ts

@@ -5,7 +5,7 @@ import { AppConfig } from '../shared/config/AppConfig';
 import { IAppConfigData } from '../shared/config/IAppConfigData';
 import BackgroundServices from './BackgroundServices';
 import FlashPlayer from './FlashPlayer';
-import checkSanity from './checkSanity';
+import checkSanity from '../shared/checkSanity';
 
 export class Main {
   private _mainWindow: MainWindow = new MainWindow(this);

Diff for: src/main/MainWindowPreload.ts

@@ -50,9 +50,9 @@ window.External = Object.freeze({
     // (Slicing a "remote object" array will make a local copy of it - i think)
     if (callback) {
       // (Returns undefined if a callback is passed)
-      Electron.remote.dialog.showOpenDialog(options, 
+      Electron.remote.dialog.showOpenDialog(options,
         (filePaths: string[], bookmarks: string[]) => {
-          callback(filePaths && filePaths.slice(), 
+          callback(filePaths && filePaths.slice(),
                    bookmarks && bookmarks.slice());
         }
       );

Diff for: src/renderer/components/pages/ConfigPage.tsx

@@ -3,7 +3,7 @@ import * as path from 'path';
 import { IAppConfigData } from '../../../shared/config/IAppConfigData';
 import { PathInput } from '../config/PathInput';
 import { Toggle } from '../config/Toggle';
-import { isFlashpointValidCheck } from '../../../main/checkSanity';
+import { isFlashpointValidCheck } from '../../../shared/checkSanity';
 
 export interface IConfigPageProps {
   config: IAppConfigData;

Diff for: src/main/checkSanity.ts renamed to src/shared/checkSanity.ts

@@ -1,8 +1,8 @@
 import * as fs from 'fs';
 import * as path from 'path';
 import * as util from 'util';
-import { isInstalled } from './Util';
-import { IAppConfigData } from "../shared/config/IAppConfigData";
+import { isInstalled } from '../main/Util';
+import { IAppConfigData } from "./config/IAppConfigData";
 
 const stat = util.promisify(fs.stat);
 

Diff for: webpack.config.js

@@ -1,12 +1,14 @@
 const path = require('path');
-const { CheckerPlugin } = require('awesome-typescript-loader');
+
 module.exports = {
   entry: './src/renderer/index.tsx',
   output: {
     filename: 'main.bundle.js',
     path: path.resolve(__dirname, './dist/renderer/'),
   },
-  //devtool: 'source-map',
+  // Allows importing build-in node modules in electron render.
+  // https://stackoverflow.com/questions/39417628/how-to-reference-node-fs-api-with-electron-in-typescript
+  target: 'electron-renderer',
   resolve: {
     extensions: ['.js', '.json', '.ts', '.tsx'],
   },
@@ -18,15 +20,4 @@ module.exports = {
       },
     ]
   },
-  externals: {
-    "react": "React",
-    "react-dom": "ReactDOM",
-    "react-virtualized": "ReactVirtualized",
-  },
-  plugins: [
-    new CheckerPlugin({
-      //configFileName: './tsconfig-renderer.json',
-      // compiler: ???,
-    })
-  ],
 };