Userland: Rename Core::Object to Core::EventReceiver

This is a more precise description of what this class actually does.

Author: awesomekling

Documentation/EventLoop.md

@@ -29,7 +29,7 @@ The **event loop stack** is mainly used for nesting GUI windows. Each window add
 An event loop handles several kinds of events:
 
 -   POSIX signals can be registered with `EventLoop::register_signal()`. This means that the event loop of the calling thread registers the specified POSIX signal and callback with the kernel, and you can be sure that the signal handler will run as a normal event without the weirdness that comes with POSIX signal handlers (such as unspecified thread).
--   EventLoop::post_event() allows calling code to fire an event targeting a specific Core::Object the next time the event loop is pumped.
+-   EventLoop::post_event() allows calling code to fire an event targeting a specific Core::EventReceiver the next time the event loop is pumped.
 -   Similarly, an arbitrary callback can be called on the next event loop iteration with `EventLoop::deferred_invoke()`.
 -   Timer events, i.e. events that fire after a certain timeout, possibly repeatedly, can be created with `EventLoop::register_timer` and `Object::start_timer()`. A more user-friendly version is the `Core::Timer` utility class which does the same thing and allows you to attach any callback to the timer.
 -   For when a "file" becomes readable or writeable, the utility class `Core::Notifier` interfaces with the event loop system to handle exactly that.

Ladybird/EventLoopImplementationQt.cpp

@@ -8,8 +8,8 @@
 #include "EventLoopImplementationQtEventTarget.h"
 #include <AK/IDAllocator.h>
 #include <LibCore/Event.h>
+#include <LibCore/EventReceiver.h>
 #include <LibCore/Notifier.h>
-#include <LibCore/Object.h>
 #include <LibCore/ThreadEventQueue.h>
 #include <QCoreApplication>
 #include <QTimer>
@@ -73,14 +73,14 @@ void EventLoopImplementationQt::wake()
         m_event_loop.wakeUp();
 }
 
-void EventLoopImplementationQt::post_event(Core::Object& receiver, NonnullOwnPtr<Core::Event>&& event)
+void EventLoopImplementationQt::post_event(Core::EventReceiver& receiver, NonnullOwnPtr<Core::Event>&& event)
 {
     m_thread_event_queue.post_event(receiver, move(event));
     if (&m_thread_event_queue != &Core::ThreadEventQueue::current())
         wake();
 }
 
-static void qt_timer_fired(int timer_id, Core::TimerShouldFireWhenNotVisible should_fire_when_not_visible, Core::Object& object)
+static void qt_timer_fired(int timer_id, Core::TimerShouldFireWhenNotVisible should_fire_when_not_visible, Core::EventReceiver& object)
 {
     if (should_fire_when_not_visible == Core::TimerShouldFireWhenNotVisible::No) {
         if (!object.is_visible_for_timer_purposes())
@@ -90,7 +90,7 @@ static void qt_timer_fired(int timer_id, Core::TimerShouldFireWhenNotVisible sho
     object.dispatch_event(event);
 }
 
-int EventLoopManagerQt::register_timer(Core::Object& object, int milliseconds, bool should_reload, Core::TimerShouldFireWhenNotVisible should_fire_when_not_visible)
+int EventLoopManagerQt::register_timer(Core::EventReceiver& object, int milliseconds, bool should_reload, Core::TimerShouldFireWhenNotVisible should_fire_when_not_visible)
 {
     auto& thread_data = ThreadData::the();
     auto timer = make<QTimer>();

Ladybird/EventLoopImplementationQt.h

@@ -26,7 +26,7 @@ class EventLoopManagerQt final : public Core::EventLoopManager {
     virtual ~EventLoopManagerQt() override;
     virtual NonnullOwnPtr<Core::EventLoopImplementation> make_implementation() override;
 
-    virtual int register_timer(Core::Object&, int milliseconds, bool should_reload, Core::TimerShouldFireWhenNotVisible) override;
+    virtual int register_timer(Core::EventReceiver&, int milliseconds, bool should_reload, Core::TimerShouldFireWhenNotVisible) override;
     virtual bool unregister_timer(int timer_id) override;
 
     virtual void register_notifier(Core::Notifier&) override;
@@ -67,7 +67,7 @@ class EventLoopImplementationQt final : public Core::EventLoopImplementation {
     virtual size_t pump(PumpMode) override;
     virtual void quit(int) override;
     virtual void wake() override;
-    virtual void post_event(Core::Object& receiver, NonnullOwnPtr<Core::Event>&&) override;
+    virtual void post_event(Core::EventReceiver& receiver, NonnullOwnPtr<Core::Event>&&) override;
 
     // FIXME: These APIs only exist for obscure use-cases inside SerenityOS. Try to get rid of them.
     virtual void unquit() override { }

Tests/Kernel/crash.cpp

@@ -12,7 +12,7 @@
 #    include <Kernel/Arch/x86_64/IO.h>
 #endif
 #include <LibCore/ArgsParser.h>
-#include <LibCore/Object.h>
+#include <LibCore/EventReceiver.h>
 #include <LibTest/CrashTest.h>
 #include <stdio.h>
 #include <stdlib.h>
@@ -327,7 +327,7 @@ int main(int argc, char** argv)
 
     if (do_deref_null_refptr || do_all_crash_types) {
         any_failures |= !Crash("Dereference a null RefPtr", [] {
-            RefPtr<Core::Object> p;
+            RefPtr<Core::EventReceiver> p;
             *p;
             return Crash::Failure::DidNotCrash;
         }).run(run_type);

Userland/Applications/Escalator/EscalatorWindow.h

@@ -11,7 +11,7 @@
 #include <AK/StringView.h>
 #include <AK/Vector.h>
 #include <LibCore/Account.h>
-#include <LibCore/Object.h>
+#include <LibCore/EventReceiver.h>
 #include <LibGUI/Button.h>
 #include <LibGUI/ImageWidget.h>
 #include <LibGUI/TextBox.h>

Userland/Applications/Piano/AudioPlayerLoop.h

@@ -13,7 +13,7 @@
 #include <LibAudio/Sample.h>
 #include <LibAudio/WavWriter.h>
 #include <LibCore/Event.h>
-#include <LibCore/Object.h>
+#include <LibCore/EventReceiver.h>
 #include <LibDSP/Music.h>
 #include <LibThreading/MutexProtected.h>
 #include <LibThreading/Thread.h>
@@ -22,7 +22,7 @@ class TrackManager;
 
 // Wrapper class accepting custom events to advance the track playing and forward audio data to the system.
 // This does not run on a separate thread, preventing IPC multithreading madness.
-class AudioPlayerLoop final : public Core::Object {
+class AudioPlayerLoop final : public Core::EventReceiver {
     C_OBJECT(AudioPlayerLoop)
 public:
     virtual ~AudioPlayerLoop() override;

Userland/Applications/Piano/ProcessorParameterWidget/ParameterWidget.h

@@ -7,7 +7,7 @@
 #pragma once
 
 #include <AK/NonnullRefPtr.h>
-#include <LibCore/Object.h>
+#include <LibCore/EventReceiver.h>
 #include <LibDSP/ProcessorParameter.h>
 #include <LibGUI/Label.h>
 #include <LibGUI/Widget.h>

Userland/Applications/Piano/ProcessorParameterWidget/Toggle.h

@@ -6,7 +6,7 @@
 
 #pragma once
 
-#include <LibCore/Object.h>
+#include <LibCore/EventReceiver.h>
 #include <LibDSP/ProcessorParameter.h>
 #include <LibGUI/CheckBox.h>
 #include <LibGUI/Widget.h>

Userland/Applications/PixelPaint/ScopeWidget.h

@@ -7,7 +7,7 @@
 #pragma once
 
 #include "Image.h"
-#include <LibCore/Object.h>
+#include <LibCore/EventReceiver.h>
 #include <LibGUI/Frame.h>
 
 namespace PixelPaint {

Userland/Applications/SoundPlayer/SoundPlayerWidget.h

@@ -33,7 +33,7 @@ class SoundPlayerWidget final : public GUI::Widget
         m_visualization->remove_from_parent();
         update();
         auto new_visualization = T::construct(move(args)...);
-        m_player_view->insert_child_before(new_visualization, *static_cast<Core::Object*>(m_playback_progress_slider.ptr()));
+        m_player_view->insert_child_before(new_visualization, *static_cast<Core::EventReceiver*>(m_playback_progress_slider.ptr()));
         m_visualization = new_visualization;
         if (!loaded_filename().is_empty())
             m_visualization->start_new_file(loaded_filename());

Userland/Applications/Spreadsheet/Spreadsheet.h

@@ -17,7 +17,7 @@
 #include <AK/Types.h>
 #include <AK/WeakPtr.h>
 #include <AK/Weakable.h>
-#include <LibCore/Object.h>
+#include <LibCore/EventReceiver.h>
 #include <LibJS/Interpreter.h>
 
 namespace Spreadsheet {
@@ -41,7 +41,7 @@ class CellChange {
     CellTypeMetadata m_new_type_metadata;
 };
 
-class Sheet : public Core::Object {
+class Sheet : public Core::EventReceiver {
     C_OBJECT(Sheet);
 
 public:

Userland/Applications/SystemMonitor/GraphWidget.cpp

@@ -6,7 +6,7 @@
  */
 
 #include "GraphWidget.h"
-#include <LibCore/Object.h>
+#include <LibCore/EventReceiver.h>
 #include <LibGUI/Application.h>
 #include <LibGUI/Painter.h>
 #include <LibGfx/Font/Font.h>

Userland/Applications/SystemMonitor/MemoryStatsWidget.cpp

@@ -9,7 +9,7 @@
 #include "GraphWidget.h"
 #include <AK/JsonObject.h>
 #include <AK/NumberFormat.h>
-#include <LibCore/Object.h>
+#include <LibCore/EventReceiver.h>
 #include <LibGUI/BoxLayout.h>
 #include <LibGUI/Label.h>
 #include <LibGUI/Painter.h>

Userland/Applications/SystemMonitor/ThreadStackWidget.cpp

@@ -126,7 +126,7 @@ void ThreadStackWidget::refresh()
         [weak_this = make_weak_ptr()](auto result) -> ErrorOr<void> {
             if (!weak_this)
                 return {};
-            Core::EventLoop::current().post_event(const_cast<Core::Object&>(*weak_this), make<CompletionEvent>(move(result)));
+            Core::EventLoop::current().post_event(const_cast<Core::EventReceiver&>(*weak_this), make<CompletionEvent>(move(result)));
             return {};
         });
 }

Userland/Applications/SystemMonitor/main.cpp

@@ -21,7 +21,7 @@
 #include <LibConfig/Client.h>
 #include <LibCore/ArgsParser.h>
 #include <LibCore/EventLoop.h>
-#include <LibCore/Object.h>
+#include <LibCore/EventReceiver.h>
 #include <LibCore/System.h>
 #include <LibCore/Timer.h>
 #include <LibGUI/Action.h>

Userland/DevTools/GMLPlayground/MainWidget.cpp

@@ -90,7 +90,7 @@ ErrorOr<NonnullRefPtr<MainWidget>> MainWidget::try_create(GUI::Icon const& icon)
     main_widget->m_editor->on_change = [main_widget = main_widget.ptr()] {
         main_widget->m_preview->remove_all_children();
         // FIXME: Parsing errors happen while the user is typing. What should we do about them?
-        (void)main_widget->m_preview->load_from_gml(main_widget->m_editor->text(), [](DeprecatedString const& class_name) -> ErrorOr<NonnullRefPtr<Core::Object>> {
+        (void)main_widget->m_preview->load_from_gml(main_widget->m_editor->text(), [](DeprecatedString const& class_name) -> ErrorOr<NonnullRefPtr<Core::EventReceiver>> {
             return UnregisteredWidget::try_create(class_name);
         });
     };

Userland/DevTools/HackStudio/GMLPreviewWidget.cpp

@@ -28,7 +28,7 @@ void GMLPreviewWidget::load_gml(DeprecatedString const& gml)
     }
 
     // FIXME: Parsing errors happen while the user is typing. What should we do about them?
-    (void)load_from_gml(gml, [](DeprecatedString const& name) -> ErrorOr<NonnullRefPtr<Core::Object>> {
+    (void)load_from_gml(gml, [](DeprecatedString const& name) -> ErrorOr<NonnullRefPtr<Core::EventReceiver>> {
         return GUI::Label::try_create(TRY(String::formatted("{} is not registered as a GML element!", name)));
     });
 

Userland/DevTools/HackStudio/Locator.cpp

@@ -95,7 +95,7 @@ LocatorSuggestionModel::Suggestion LocatorSuggestionModel::Suggestion::create_sy
     return s;
 }
 
-Locator::Locator(Core::Object* parent)
+Locator::Locator(Core::EventReceiver* parent)
 {
     set_layout<GUI::VerticalBoxLayout>();
     set_fixed_height(22);

Userland/DevTools/HackStudio/Locator.h

@@ -24,7 +24,7 @@ class Locator final : public GUI::Widget {
     void update_suggestions();
     void open_suggestion(const GUI::ModelIndex&);
 
-    Locator(Core::Object* parent = nullptr);
+    Locator(Core::EventReceiver* parent = nullptr);
 
     RefPtr<GUI::TextBox> m_textbox;
     RefPtr<GUI::Window> m_popup_window;

Userland/DevTools/HackStudio/ProjectConfig.h

@@ -10,7 +10,7 @@
 #include <AK/JsonObject.h>
 #include <AK/Optional.h>
 #include <AK/OwnPtr.h>
-#include <LibCore/Object.h>
+#include <LibCore/EventReceiver.h>
 
 namespace HackStudio {
 

Userland/Libraries/LibAudio/ConnectionToServer.h

@@ -14,7 +14,7 @@
 #include <LibAudio/Queue.h>
 #include <LibAudio/UserSampleQueue.h>
 #include <LibCore/EventLoop.h>
-#include <LibCore/Object.h>
+#include <LibCore/EventReceiver.h>
 #include <LibIPC/ConnectionToServer.h>
 #include <LibThreading/Mutex.h>
 #include <LibThreading/Thread.h>

Userland/Libraries/LibCards/Card.h

@@ -9,7 +9,7 @@
 #pragma once
 
 #include <AK/Format.h>
-#include <LibCore/Object.h>
+#include <LibCore/EventReceiver.h>
 #include <LibGUI/Painter.h>
 #include <LibGfx/Bitmap.h>
 #include <LibGfx/CharacterBitmap.h>
@@ -77,7 +77,7 @@ enum class Suit : u8 {
     __Count
 };
 
-class Card final : public Core::Object {
+class Card final : public Core::EventReceiver {
     C_OBJECT(Card)
 public:
     static constexpr int width = 80;

Userland/Libraries/LibChess/UCIEndpoint.cpp

@@ -51,7 +51,7 @@ void Endpoint::event(Core::Event& event)
     case Command::Type::UCINewGame:
         return handle_ucinewgame();
     default:
-        Object::event(event);
+        EventReceiver::event(event);
         break;
     }
 }

Userland/Libraries/LibChess/UCIEndpoint.h

@@ -8,13 +8,13 @@
 #pragma once
 
 #include <LibChess/UCICommand.h>
+#include <LibCore/EventReceiver.h>
 #include <LibCore/File.h>
 #include <LibCore/Notifier.h>
-#include <LibCore/Object.h>
 
 namespace Chess::UCI {
 
-class Endpoint : public Core::Object {
+class Endpoint : public Core::EventReceiver {
     C_OBJECT(Endpoint)
 public:
     virtual ~Endpoint() override = default;

Userland/Libraries/LibCore/CMakeLists.txt

@@ -12,13 +12,13 @@ set(SOURCES
     EventLoop.cpp
     EventLoopImplementation.cpp
     EventLoopImplementationUnix.cpp
+    EventReceiver.cpp
     File.cpp
     LockFile.cpp
     MappedFile.cpp
     MimeData.cpp
     NetworkJob.cpp
     Notifier.cpp
-    Object.cpp
     Process.cpp
     ProcessStatisticsReader.cpp
     SecretString.cpp

Userland/Libraries/LibCore/DeferredInvocationContext.h

@@ -7,11 +7,11 @@
 
 #pragma once
 
-#include <LibCore/Object.h>
+#include <LibCore/EventReceiver.h>
 
 namespace Core {
 
-class DeferredInvocationContext final : public Core::Object {
+class DeferredInvocationContext final : public Core::EventReceiver {
     C_OBJECT(DeferredInvocationContext)
 private:
     DeferredInvocationContext() = default;

Userland/Libraries/LibCore/Event.cpp

@@ -7,39 +7,39 @@
 
 #include <AK/WeakPtr.h>
 #include <LibCore/Event.h>
-#include <LibCore/Object.h>
+#include <LibCore/EventReceiver.h>
 
 namespace Core {
 
-ChildEvent::ChildEvent(Type type, Object& child, Object* insertion_before_child)
+ChildEvent::ChildEvent(Type type, EventReceiver& child, EventReceiver* insertion_before_child)
     : Core::Event(type)
     , m_child(child.make_weak_ptr())
     , m_insertion_before_child(AK::make_weak_ptr_if_nonnull(insertion_before_child))
 {
 }
 
-Object* ChildEvent::child()
+EventReceiver* ChildEvent::child()
 {
     if (auto ref = m_child.strong_ref())
         return ref.ptr();
     return nullptr;
 }
 
-Object const* ChildEvent::child() const
+EventReceiver const* ChildEvent::child() const
 {
     if (auto ref = m_child.strong_ref())
         return ref.ptr();
     return nullptr;
 }
 
-Object* ChildEvent::insertion_before_child()
+EventReceiver* ChildEvent::insertion_before_child()
 {
     if (auto ref = m_insertion_before_child.strong_ref())
         return ref.ptr();
     return nullptr;
 }
 
-Object const* ChildEvent::insertion_before_child() const
+EventReceiver const* ChildEvent::insertion_before_child() const
 {
     if (auto ref = m_insertion_before_child.strong_ref())
         return ref.ptr();

Userland/Libraries/LibCore/Event.h

@@ -95,18 +95,18 @@ class NotifierActivationEvent final : public Event {
 
 class ChildEvent final : public Event {
 public:
-    ChildEvent(Type, Object& child, Object* insertion_before_child = nullptr);
+    ChildEvent(Type, EventReceiver& child, EventReceiver* insertion_before_child = nullptr);
     ~ChildEvent() = default;
 
-    Object* child();
-    Object const* child() const;
+    EventReceiver* child();
+    EventReceiver const* child() const;
 
-    Object* insertion_before_child();
-    Object const* insertion_before_child() const;
+    EventReceiver* insertion_before_child();
+    EventReceiver const* insertion_before_child() const;
 
 private:
-    WeakPtr<Object> m_child;
-    WeakPtr<Object> m_insertion_before_child;
+    WeakPtr<EventReceiver> m_child;
+    WeakPtr<EventReceiver> m_insertion_before_child;
 };
 
 class CustomEvent : public Event {