Skip to content

Allow configurable timeout for Jar Remapping ? #1114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Yldales opened this issue May 29, 2024 · 1 comment · Fixed by #1053
Closed

Allow configurable timeout for Jar Remapping ? #1114

Yldales opened this issue May 29, 2024 · 1 comment · Fixed by #1053
Assignees
Labels
enhancement New feature or request fixed in dev Fixed in dev. Awaiting a new release.

Comments

@Yldales
Copy link

Yldales commented May 29, 2024

Hi,

The JarTransformer.class class has a hardcoded timeout value of 60 seconds for the awaitTermination method. This can be problematic in environments where large mods (like Conquest Reforged) require more time to be remapped. To enhance flexibility and address issues #275, #424 and #880, could you consider making the timeout value configurable ? 👉👈

if (!executorService.awaitTermination(60, TimeUnit.SECONDS)) {
throw new RuntimeException("Timed out waiting for jar remap");
}

Thank you in advance for your consideration.

@Su5eD Su5eD self-assigned this May 29, 2024
@Su5eD Su5eD added the enhancement New feature or request label May 29, 2024
@Su5eD Su5eD moved this from 🆕 New to 🏗 In progress in Connector Triage May 30, 2024
@Su5eD Su5eD added the fixed in dev Fixed in dev. Awaiting a new release. label May 30, 2024
@Su5eD Su5eD moved this from 🏗 In progress to 👀 In review in Connector Triage May 30, 2024
@Su5eD
Copy link
Member

Su5eD commented May 30, 2024

I "removed" the delay by setting it to one hour (a timeout duration is always required by Java's thread executor), which should suffice. I don't expect transformation to actually freeze up, and all reported cases so far seem related to available system resources, so hopefully no issues arise after this change either.

@Su5eD Su5eD linked a pull request May 30, 2024 that will close this issue
@Su5eD Su5eD closed this as completed in f6aabf9 Jun 21, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Connector Triage Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed in dev Fixed in dev. Awaiting a new release.
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants