You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The JarTransformer.class class has a hardcoded timeout value of 60 seconds for the awaitTermination method. This can be problematic in environments where large mods (like Conquest Reforged) require more time to be remapped. To enhance flexibility and address issues #275, #424 and #880, could you consider making the timeout value configurable ? 👉👈
I "removed" the delay by setting it to one hour (a timeout duration is always required by Java's thread executor), which should suffice. I don't expect transformation to actually freeze up, and all reported cases so far seem related to available system resources, so hopefully no issues arise after this change either.
Hi,
The JarTransformer.class class has a hardcoded timeout value of 60 seconds for the awaitTermination method. This can be problematic in environments where large mods (like Conquest Reforged) require more time to be remapped. To enhance flexibility and address issues #275, #424 and #880, could you consider making the timeout value configurable ? 👉👈
Connector/src/main/java/dev/su5ed/sinytra/connector/transformer/jar/JarTransformer.java
Lines 152 to 154 in 31aa8e6
Thank you in advance for your consideration.
The text was updated successfully, but these errors were encountered: