Skip to content

Connector cannot use with "RunData" in dev #1128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joe-vettek opened this issue Jun 6, 2024 · 0 comments
Closed

Connector cannot use with "RunData" in dev #1128

joe-vettek opened this issue Jun 6, 2024 · 0 comments
Assignees
Labels
bug Something isn't working fixed in dev Fixed in dev. Awaiting a new release.

Comments

@joe-vettek
Copy link

joe-vettek commented Jun 6, 2024

Minecraft version

1.20.1

Describe the bug

Connector currently works with the development environment runclient, but I found it does not work with the rundata command. In fact, it does not load the Fabric module. Those items and blocks are not registered to the registry.

Steps to reproduce

  1. add in gradle file
repositories {
    maven {
        url "https://www.cursemaven.com"
    }
    maven {
        name = "Sinytra"
        url = "https://maven.su5ed.dev/releases"
    }
    // Other repositories can go above or below Modrinth's. We don't need priority :)
    exclusiveContent {
        forRepository {
            maven {
                name = "Modrinth"
                url = "https://api.modrinth.com/maven"
            }
        }
        forRepositories(fg.repository) // Only add this if you're using ForgeGradle, otherwise remove this line
        filter {
            includeGroup "maven.modrinth"
        }
    }
}
dependencies {
    minecraft "net.minecraftforge:forge:${minecraft_min_version}-47.1.3"
    minecraftLibrary fg.deobf("dev.su5ed.sinytra:Connector:1.0.0-beta.43+1.20.1")

    runtimeOnly fg.deobf("curse.maven:terrablender-563928:5378180")
    runtimeOnly "maven.modrinth:natures-spirit:1.5.1-1.20.1"

    runtimeOnly fg.deobf("dev.su5ed.sinytra.fabric-api:fabric-api:0.92.0+1.11.5+1.20.1")
}
  1. rundata
  2. check the registries when GatherDataEvent is fired

Logs

No response

Additional context

No response

@joe-vettek joe-vettek added the bug Something isn't working label Jun 6, 2024
@Su5eD Su5eD self-assigned this Jun 6, 2024
@Su5eD Su5eD moved this from 🆕 New to 👀 In review in Connector Triage Jun 6, 2024
@Su5eD Su5eD added the fixed in dev Fixed in dev. Awaiting a new release. label Jun 6, 2024
@Su5eD Su5eD closed this as completed in 91b161f Jun 21, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Connector Triage Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed in dev Fixed in dev. Awaiting a new release.
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants